Use the added constants

Author: bouwew

plugwise/__init__.py

@@ -16,6 +16,7 @@
 import semver
 
 from .constants import (
+    ADAM,
     APPLIANCES,
     DEFAULT_PORT,
     DEFAULT_TIMEOUT,
@@ -113,7 +114,7 @@ def _update_gw_devices(self) -> None:
             device.update(data)
 
             # Update for cooling
-            if device["dev_class"] in ZONE_THERMOSTATS and self.smile_name != "Adam":
+            if device["dev_class"] in ZONE_THERMOSTATS and self.smile_name != ADAM:
                 self.update_for_cooling(device)
 
             remove_empty_platform_dicts(device)
@@ -187,7 +188,7 @@ def _device_data_adam(
         """
         # Indicate heating_state based on valves being open in case of city-provided heating
         if (
-            self.smile_name == "Adam"
+            self.smile_name == ADAM
             and device.get("dev_class") == "heater_central"
             and self._on_off_device
             and self._heating_valves() is not None
@@ -662,7 +663,7 @@ async def set_schedule_state(
         template = (
             '<template tag="zone_preset_based_on_time_and_presence_with_override" />'
         )
-        if self.smile_name != "Adam":
+        if self.smile_name != ADAM:
             locator = f'.//*[@id="{schedule_rule_id}"]/template'
             template_id = self._domain_objects.find(locator).attrib["id"]
             template = f'<template id="{template_id}" />'
@@ -715,7 +716,7 @@ async def set_temperature(self, loc_id: str, items: dict[str, float]) -> None:
         if "setpoint" in items:
             setpoint = items["setpoint"]
 
-        if self._cooling_present and self.smile_name != "Adam":
+        if self._cooling_present and self.smile_name != ADAM:
             if "setpoint_high" not in items:
                 raise PlugwiseError(
                     "Plugwise: failed setting temperature: no valid input provided"

plugwise/helper.py

@@ -21,6 +21,8 @@
 from .constants import (
     ACTIVE_ACTUATORS,
     ACTUATOR_CLASSES,
+    ADAM,
+    ANNA,
     APPLIANCES,
     ATTR_NAME,
     ATTR_UNIT_OF_MEASUREMENT,
@@ -380,7 +382,7 @@ def _energy_device_info_finder(self, appliance: etree, appl: Munch) -> Munch | N
 
             return appl
 
-        if self.smile_name == "Adam":
+        if self.smile_name == ADAM:
             locator = "./logs/interval_log/electricity_interval_meter"
             mod_type = "electricity_interval_meter"
             module_data = self._get_module_data(appliance, locator, mod_type)
@@ -411,7 +413,7 @@ def _appliance_info_finder(self, appliance: etree, appl: Munch) -> Munch:
             appl.vendor_name = "Plugwise"
 
             # Adam: look for the ZigBee MAC address of the Smile
-            if self.smile_name == "Adam" and (
+            if self.smile_name == ADAM and (
                 found := self._modules.find(".//protocols/zig_bee_coordinator")
             ):
                 appl.zigbee_mac = found.find("mac_address").text
@@ -830,7 +832,7 @@ def _wireless_availablity(self, appliance: etree, data: DeviceData) -> None:
 
         Collect the availablity-status for wireless connected devices.
         """
-        if self.smile_name == "Adam":
+        if self.smile_name == ADAM:
             # Collect for Plugs
             locator = "./logs/interval_log/electricity_interval_meter"
             mod_type = "electricity_interval_meter"
@@ -951,11 +953,11 @@ def _process_c_heating_state(self, data: DeviceData) -> None:
         if self._on_off_device:
             # Anna + OnOff heater: use central_heating_state to show heating_state
             # Solution for Core issue #81839
-            if self.smile_name == "Smile Anna":
+            if self.smile_name == ANNA:
                 data["binary_sensors"]["heating_state"] = data["c_heating_state"]
 
             # Adam + OnOff cooling: use central_heating_state to show heating/cooling_state
-            if self.smile_name == "Adam":
+            if self.smile_name == ADAM:
                 if "heating_state" not in data["binary_sensors"]:
                     self._count += 1
                 data["binary_sensors"]["heating_state"] = False
@@ -1009,7 +1011,7 @@ def _get_measurement_data(self, dev_id: str) -> DeviceData:
             # Collect availability-status for wireless connected devices to Adam
             self._wireless_availablity(appliance, data)
 
-        if dev_id == self.gateway_id and self.smile_name == "Adam":
+        if dev_id == self.gateway_id and self.smile_name == ADAM:
             self._get_regulation_mode(appliance, data)
 
         if "c_heating_state" in data:
@@ -1020,7 +1022,7 @@ def _get_measurement_data(self, dev_id: str) -> DeviceData:
 
         if (
             self._is_thermostat
-            and self.smile_name == "Smile Anna"
+            and self.smile_name == ANNA
             and dev_id == self._heater_id
         ):
             # Anna+Elga: base cooling_state on the elga-status-code
@@ -1140,7 +1142,7 @@ def _get_group_switches(self) -> dict[str, DeviceData]:
         """
         switch_groups: dict[str, DeviceData] = {}
         # P1 and Anna don't have switchgroups
-        if self.smile_type == "power" or self.smile_name == "Smile Anna":
+        if self.smile_type == "power" or self.smile_name == ANNA:
             return switch_groups
 
         for group in self._domain_objects.findall("./group"):