Skip to content

Commit 9ba61a9

Browse files
committed
More mypy fixes
1 parent 0fbc753 commit 9ba61a9

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

plugwise/__init__.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
from __future__ import annotations
77

8+
from typing import cast
9+
810
from plugwise.constants import (
911
DEFAULT_LEGACY_TIMEOUT,
1012
DEFAULT_PORT,
@@ -178,7 +180,7 @@ async def connect(self) -> Version:
178180
# Update all endpoints on first connect
179181
await self._smile_api.full_xml_update()
180182

181-
return self.smile.version
183+
return cast(Version, self.smile.version)
182184

183185
async def _smile_detect(
184186
self, result: etree.Element, dsmrmain: etree.Element
@@ -199,7 +201,9 @@ async def _smile_detect(
199201
else:
200202
model = await self._smile_detect_legacy(result, dsmrmain, model)
201203

202-
if model == "Unknown" or self.smile.version is None: # pragma: no cover
204+
if model == "Unknown" or self.smile.version == Version(
205+
"0.0.0"
206+
): # pragma: no cover
203207
# Corner case check
204208
LOGGER.error(
205209
"Unable to find model or version information, please create"

plugwise/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def heater_id(self) -> str:
6464

6565
def check_name(self, name: str) -> bool:
6666
"""Helper-function checking the smile-name."""
67-
return self.smile.name == name
67+
return bool(self.smile.name == name)
6868

6969
def _appl_heater_central_info(
7070
self,

0 commit comments

Comments
 (0)