Save TODO

Author: bouwew

plugwise/data.py

@@ -166,13 +166,14 @@ def _get_location_data(self, loc_id: str) -> GwEntityData:
             if str(ctrl_state) in ("cooling", "heating", "preheating"):
                 data["control_state"] = str(ctrl_state)
                 self._count += 1
-            else:
+            if str(ctrl_state) == "off":
                 data["control_state"] = "idle"
                 self._count += 1
         # control_state not present in regulation+mode off (issue #776)
         elif self.smile_version >= version.parse("3.2.0"):
             data["control_state"] = "idle"
             self._count += 1
+            # TODO: add testcase with regulation_mode off and control_state key not present
 
         # Thermostat data (presets, temperatures etc)
         self._climate_data(loc_id, zone, data)

plugwise/helper.py

@@ -259,6 +259,7 @@ def __init__(self) -> None:
         self.smile_model_id: str | None
         self.smile_name: str
         self.smile_type: str
+        self.smile_version: str
         self.smile_zigbee_mac_address: str | None
         self.therms_with_offset_func: list[str] = []
         self._zones: dict[str, GwEntityData] = {}