Skip to content

Commit abf6cec

Browse files
committed
Improve _add_member()
1 parent 3f67ea5 commit abf6cec

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

plugwise/common.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def _get_groups(self) -> None:
213213
group_type = group.find("type").text
214214
group_appliances = group.findall("appliances/appliance")
215215
for item in group_appliances:
216-
self._add_member(item)
216+
self._add_member(item, members)
217217

218218
if group_type in GROUP_TYPES and members:
219219
self.gw_entities[group_id] = {
@@ -235,8 +235,8 @@ def _get_groups(self) -> None:
235235

236236
def _add_member(self, element: etree.Element, members: list[str]) -> None:
237237
"""Check and add member to list."""
238-
if element.attrib["id"] in self.gw_entities:
239-
members.append(item.attrib["id"])
238+
if (member_id := element.attrib["id"]) in self.gw_entities:
239+
members.append(member_id)
240240

241241
def _get_lock_state(
242242
self, xml: etree.Element, data: GwEntityData, stretch_v2: bool = False

0 commit comments

Comments
 (0)