Skip to content

Commit bbd436e

Browse files
committed
Translate back to str
1 parent 31136ff commit bbd436e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

plugwise/helper.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
from dateutil.parser import parse
6363
from defusedxml import ElementTree as etree
6464
from munch import Munch
65+
from packaging.version import Version
6566

6667

6768
class SmileComm:
@@ -250,7 +251,7 @@ def __init__(self) -> None:
250251
self.gw_data: GatewayData = {}
251252
self.gw_devices: dict[str, DeviceData] = {}
252253
self.loc_data: dict[str, ThermoLoc]
253-
self.smile_fw_version: str | None
254+
self.smile_fw_version: Version | None
254255
self.smile_hw_version: str | None
255256
self.smile_mac_address: str | None
256257
self.smile_model: str
@@ -425,7 +426,7 @@ def _energy_device_info_finder(self, appl: Munch, appliance: etree) -> Munch:
425426
def _appl_gateway_info(self, appl: Munch, appliance: etree) -> Munch:
426427
"""Helper-function for _appliance_info_finder()."""
427428
self.gateway_id = appliance.attrib["id"]
428-
appl.firmware = self.smile_fw_version
429+
appl.firmware = str(self.smile_fw_version)
429430
appl.hardware = self.smile_hw_version
430431
appl.mac = self.smile_mac_address
431432
appl.model = self.smile_model

plugwise/legacy/helper.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
# This way of importing aiohttp is because of patch/mocking in testing (aiohttp timeouts)
4545
from defusedxml import ElementTree as etree
4646
from munch import Munch
47+
from packaging.version import Version
4748

4849

4950
def etree_to_dict(element: etree) -> dict[str, str]:
@@ -81,7 +82,7 @@ def __init__(self) -> None:
8182
self.gw_data: GatewayData = {}
8283
self.gw_devices: dict[str, DeviceData] = {}
8384
self.loc_data: dict[str, ThermoLoc]
84-
self.smile_fw_version: str | None
85+
self.smile_fw_version: Version | None
8586
self.smile_hw_version: str | None
8687
self.smile_mac_address: str | None
8788
self.smile_model: str
@@ -194,7 +195,7 @@ def _create_legacy_gateway(self) -> None:
194195
self.gw_devices[self.gateway_id] = {"dev_class": "gateway"}
195196
self._count += 1
196197
for key, value in {
197-
"firmware": self.smile_fw_version,
198+
"firmware": str(self.smile_fw_version),
198199
"location": self._home_location,
199200
"mac_address": self.smile_mac_address,
200201
"model": self.smile_model,

0 commit comments

Comments
 (0)