Skip to content

Commit c28234d

Browse files
committed
Add and improve comments
1 parent c806aa2 commit c28234d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

plugwise/helper.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,7 @@ def _get_appliance_data(self, d_id):
742742
Determined from APPLIANCES, for legacy from DOMAIN_OBJECTS.
743743
"""
744744
data = {}
745+
# P1 legacy has no APPLIANCES, also not present in DOMAIN_OBJECTS
745746
if self._smile_legacy and self.smile_type == "power":
746747
return data
747748

@@ -861,6 +862,7 @@ def _group_switches(self):
861862
Collect switching- or pump-group info.
862863
"""
863864
switch_groups = {}
865+
# P1 and Anna don't have switch groups
864866
if self.smile_type == "power" or self.smile_name == "Anna":
865867
return switch_groups
866868

@@ -926,7 +928,7 @@ def _power_data_peak_value(self, loc):
926928

927929
# Only once try to find P1 Legacy values
928930
if loc.logs.find(loc.locator) is None and self.smile_type == "power":
929-
# Skip peak if not split (P1 Legacy)
931+
# Skip peak if not split (P1 Legacy), this also results in one (peak_)point sensor for all P1's.
930932
if loc.peak_select == "nl_offpeak":
931933
loc.found = False
932934
return loc
@@ -965,6 +967,7 @@ def _power_data_from_location(self, loc_id):
965967
search = self._domain_objects
966968
t_string = "tariff"
967969
if self.smile_type == "power":
970+
# P1: use data from LOCATIONS
968971
search = self._locations
969972
if self._smile_legacy:
970973
t_string = "tariff_indicator"

0 commit comments

Comments
 (0)