Implement control_state work=around for older Adam firmware

Author: bouwew

plugwise/data.py

@@ -162,7 +162,7 @@ def _get_location_data(self, loc_id: str) -> GwEntityData:
         """
         zone = self._zones[loc_id]
         data = self._get_zone_data(loc_id)
-        if ctrl_state := self._control_state(loc_id):
+        if ctrl_state := self._control_state(data, loc_id):
             if str(ctrl_state) in ("cooling", "heating", "preheating"):
                 data["control_state"] = str(ctrl_state)
                 self._count += 1
@@ -174,6 +174,9 @@ def _get_location_data(self, loc_id: str) -> GwEntityData:
             data["control_state"] = "idle"
             self._count += 1
 
+        data.pop("setpoint")  # remove, only used in _control_state()
+        self._count -= 1
+
         # Thermostat data (presets, temperatures etc)
         self._climate_data(loc_id, zone, data)
 

plugwise/helper.py

@@ -918,7 +918,7 @@ def _rank_thermostat(
             else:
                 thermo_loc["secondary"].append(appliance_id)
 
-    def _control_state(self, loc_id: str) -> str | bool:
+    def _control_state(self, data: GwEntityData, loc_id: str) -> str:
         """Helper-function for _get_adam_data().
 
         Adam: find the thermostat control_state of a location, from DOMAIN_OBJECTS.
@@ -929,9 +929,14 @@ def _control_state(self, loc_id: str) -> str | bool:
         if (location := self._domain_objects.find(locator)) is not None:
             locator = './actuator_functionalities/thermostat_functionality[type="thermostat"]/control_state'
             if (ctrl_state := location.find(locator)) is not None:
-                return str(ctrl_state.text)
-
-        return False
+                return ctrl_state.text
+
+        # Older Adam firmware does not have the control_state key
+        # Work around this by comparing the reported temperature and setpoint for a location
+        setpoint = data["setpoint"]
+        temperature = data["temperature"]
+        # No cooling available in older firmware
+        return "heating" if temperature < setpoint else "idle"
 
     def _heating_valves(self) -> int | bool:
         """Helper-function for smile.py: _get_adam_data().