Skip to content

Commit df31a93

Browse files
committed
Don't tinker_schedule when no schedule selected
1 parent 3a6ccc8 commit df31a93

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

tests/test_smile.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,7 @@ async def tinker_thermostat_schedule(
556556

557557
@pytest.mark.asyncio
558558
async def tinker_thermostat(
559-
self, smile, loc_id, good_schedules=None, unhappy=False
559+
self, smile, loc_id, schedule_on=False, good_schedules=None, unhappy=False
560560
):
561561
"""Toggle various climate settings to test functionality."""
562562
if good_schedules is None: # pragma: no cover
@@ -567,12 +567,13 @@ async def tinker_thermostat(
567567
await self.tinker_thermostat_schedule(
568568
smile, loc_id, "on", good_schedules, unhappy
569569
)
570-
await self.tinker_thermostat_schedule(
571-
smile, loc_id, "off", good_schedules, unhappy
572-
)
573-
await self.tinker_thermostat_schedule(
574-
smile, loc_id, "on", good_schedules, unhappy
575-
)
570+
if schedule_on:
571+
await self.tinker_thermostat_schedule(
572+
smile, loc_id, "off", good_schedules, unhappy
573+
)
574+
await self.tinker_thermostat_schedule(
575+
smile, loc_id, "on", good_schedules, unhappy
576+
)
576577

577578
@staticmethod
578579
async def tinker_regulation_mode(smile):
@@ -959,6 +960,7 @@ async def test_connect_anna_v4(self):
959960
await self.tinker_thermostat(
960961
smile,
961962
"eb5309212bf5407bb143e5bfa3b18aee",
963+
schedule_on=False,
962964
good_schedules=["Standaard", "Thuiswerken"],
963965
)
964966
await smile.close_connection()
@@ -968,6 +970,7 @@ async def test_connect_anna_v4(self):
968970
await self.tinker_thermostat(
969971
smile,
970972
"eb5309212bf5407bb143e5bfa3b18aee",
973+
schedule_on=False,
971974
good_schedules=["Standaard", "Thuiswerken"],
972975
unhappy=True,
973976
)
@@ -1055,6 +1058,7 @@ async def test_connect_anna_v4_dhw(self):
10551058
await self.tinker_thermostat(
10561059
smile,
10571060
"eb5309212bf5407bb143e5bfa3b18aee",
1061+
schedule_on=False,
10581062
good_schedules=["Standaard", "Thuiswerken"],
10591063
)
10601064
await smile.close_connection()
@@ -1065,6 +1069,7 @@ async def test_connect_anna_v4_dhw(self):
10651069
smile,
10661070
"eb5309212bf5407bb143e5bfa3b18aee",
10671071
good_schedules=["Standaard", "Thuiswerken"],
1072+
schedule_on=False,
10681073
unhappy=True,
10691074
)
10701075
await smile.close_connection()
@@ -1096,6 +1101,7 @@ async def test_connect_anna_v4_no_tag(self):
10961101
await self.tinker_thermostat(
10971102
smile,
10981103
"eb5309212bf5407bb143e5bfa3b18aee",
1104+
schedule_on=False,
10991105
good_schedules=["Standaard", "Thuiswerken"],
11001106
)
11011107
await smile.close_connection()
@@ -1105,6 +1111,7 @@ async def test_connect_anna_v4_no_tag(self):
11051111
await self.tinker_thermostat(
11061112
smile,
11071113
"eb5309212bf5407bb143e5bfa3b18aee",
1114+
schedule_on=False,
11081115
good_schedules=["Standaard", "Thuiswerken"],
11091116
unhappy=True,
11101117
)

0 commit comments

Comments
 (0)