Improve comments, add missed data["cooling_state"] init

Author: bouwew

plugwise/helper.py

@@ -940,12 +940,12 @@ def _cleanup_data(self, data: dict[str, Any]) -> None:
         if "temperature" in data:
             data.pop("heating_state", None)
 
-        # Don't show cooling-related when no cooling present
+        # Don't show cooling-related when no cooling present,
+        # but, keep cooling_enabled for Elga
         if not self._cooling_present:
             for item in ("cooling_state", "cooling_ena_switch"):
                 if item in data:
                     data.pop(item)
-            # Keep cooling_enabled for Elga
             if not self._elga and "cooling_enabled" in data:
                 data.pop("cooling_enabled")  # pragma: no cover
 
@@ -960,16 +960,16 @@ def _process_c_heating_state(self, data: dict[str, Any]) -> None:
             if self.smile_name == "Smile Anna":
                 data["heating_state"] = data["c_heating_state"]
 
+            # Adam + OnOff cooling: use central_heating_state to show heating/cooling_state
             if self.smile_name == "Adam":
-                data["heating_state"] = False
-                # Adam + OnOff cooling: use central_heating_state to show heating/cooling_state
+                data["cooling_state"] = data["heating_state"] = False
                 if self._cooling_enabled:
                     data["cooling_state"] = data["c_heating_state"]
                 else:
                     data["heating_state"] = data["c_heating_state"]
 
+        # Anna + Elga: use central_heating_state to show heating_state
         if self._elga:
-            # Anna + Elga: use central_heating_state to show heating_state
             data["heating_state"] = data["c_heating_state"]
 
     def _get_appliance_data(self, d_id: str) -> DeviceData:
@@ -1011,8 +1011,8 @@ def _get_appliance_data(self, d_id: str) -> DeviceData:
             data.pop("c_heating_state")
 
         if d_id == self._heater_id and self.smile_name == "Smile Anna":
+            # Anna+Elga: base cooling_state on the elga-status-code
             if "elga_status_code" in data:
-                # Base cooling_state on the elga-status-code
                 data["cooling_state"] = self._cooling_active = (
                     data["elga_status_code"] == 8
                 )
@@ -1026,8 +1026,10 @@ def _get_appliance_data(self, d_id: str) -> DeviceData:
                 # Elga has no cooling-switch
                 if "cooling_ena_switch" in data:
                     data.pop("cooling_ena_switch")
+
+            # Loria/Thermastage: cooling-related is based on cooling_state
+            # and modulation_level
             else:
-                # Loria/Thermastage: cooling-related is based on cooling_state and modulation_level
                 if self._cooling_present and "cooling_state" in data:
                     self._cooling_enabled = data["cooling_state"]
                     self._cooling_active = data["modulation_level"] == 100