Add subscription upsert to finalize checkout (#1472)

Author: michaeljguarino

apps/core/lib/core/services/payments.ex

@@ -212,8 +212,9 @@ defmodule Core.Services.Payments do
     end
   end
 
-  def finalize_checkout(%Stripe.Checkout.Session{customer: cus_id, subscription: sub_id}, %User{} = user) when is_binary(cus_id) and is_binary(sub_id) do
-    %{account: account} = Repo.preload(user, [:account])
+  def finalize_checkout(%Stripe.Checkout.Session{customer: cus_id, subscription: sub_id}, %User{} = user)
+      when is_binary(cus_id) and is_binary(sub_id) do
+    %{account: account} = Repo.preload(user, [account: :subscription])
     start_transaction()
     |> add_operation(:account, fn _ ->
       account
@@ -222,9 +223,16 @@ defmodule Core.Services.Payments do
     end)
     |> add_operation(:subscription, fn _ ->
       plan = pro_plan!()
-      %PlatformSubscription{account_id: account.id}
-      |> PlatformSubscription.changeset(%{external_id: sub_id, plan_id: plan.id, billing_version: 1})
-      |> Core.Repo.insert()
+      case account.subscription do
+        %PlatformSubscription{} = sub -> sub
+        nil -> %PlatformSubscription{account_id: account.id}
+      end
+      |> PlatformSubscription.changeset(%{
+        external_id: sub_id,
+        plan_id: plan.id,
+        billing_version: 1
+      })
+      |> Core.Repo.insert_or_update()
     end)
     |> execute(extract: :subscription)
   end

apps/core/test/services/payments_test.exs

@@ -1080,6 +1080,27 @@ defmodule Core.Services.PaymentsTest do
 
       assert account.billing_customer_id == "cus_id"
     end
+
+    test "it will finalize even if a subscription exists" do
+      account = insert(:account)
+      user = insert(:user, account: account)
+      insert(:platform_subscription, account: account)
+      plan = pro_plan()
+      expect(Stripe.Checkout.Session, :retrieve, fn "session_id" ->
+        {:ok, %Stripe.Checkout.Session{customer: "cus_id", subscription: "sub_id"}}
+      end)
+
+      {:ok, subscription} = Payments.finalize_checkout("session_id", user)
+
+      assert subscription.account_id == account.id
+      assert subscription.external_id == "sub_id"
+      assert subscription.plan_id == plan.id
+      assert subscription.billing_version == 1
+
+      %{account: account} = Repo.preload(subscription, [:account])
+
+      assert account.billing_customer_id == "cus_id"
+    end
   end
 
   describe "#backfill_subscription/3" do