Skip pageAction on Firefox for Android

Fixes #67 again

Author: pmarks-net

src/background.js

@@ -143,12 +143,19 @@ function reformatForNAT64(addr, doLookup=true) {
   return formatIPv6(packed128, /*with_dots=*/isNAT64);
 }
 
-// Magic object that calls action and/or pageAction. We want an icon in the
-// address bar when possible (e.g. desktop Firefox) but have a fallback option
-// when browsers forget to implement pageAction (e.g. Firefox 142 for Android).
+// Magic object that forwards calls to action and/or pageAction.
+// - Chrome: action only (pageAction not in manifest)
+// - Firefox mobile: action only (pageAction is broken on v142-143)
+// - Firefox desktop: action + pageAction (redundant icons)
+//
+// Originally, Firefox used pageAction only, until v142-143 broke it:
+// https://bugzilla.mozilla.org/show_bug.cgi?id=1984835
 const actions = new Proxy({}, {
   get(target, prop) {
-    const apis = [chrome.action, chrome.pageAction].filter(Boolean);
+    const apis = [chrome.action];
+    if (chrome.pageAction && !IS_MOBILE) {
+      apis.push(chrome.pageAction);
+    }
     return (...args) => {
       for (const api of apis) {
         if (typeof api[prop] === 'function') {

src/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.25",
+  "version": "2.26",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {

src/manifest/chrome-manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.25",
+  "version": "2.26",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {

src/manifest/firefox-manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.25",
+  "version": "2.26",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {