Skip to content

Commit b596734

Browse files
authored
Update opentracing and opencesus docs examples to not use JaegerExporter (#4023)
1 parent 78c19dc commit b596734

File tree

6 files changed

+27
-21
lines changed

6 files changed

+27
-21
lines changed

docs/examples/opencensus-shim/README.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ Start Jaeger
2020
.. code-block:: sh
2121
2222
docker run --rm \
23-
-p 6831:6831/udp \
24-
-p 6832:6832/udp \
23+
-p 4317:4317 \
24+
-p 4318:4318 \
2525
-p 16686:16686 \
26-
jaegertracing/all-in-one:1.13 \
26+
jaegertracing/all-in-one:latest \
2727
--log-level=debug
2828
2929
Python Dependencies
@@ -43,7 +43,7 @@ Alternatively, you can install the Python dependencies separately:
4343
pip install \
4444
opentelemetry-api \
4545
opentelemetry-sdk \
46-
opentelemetry-exporter-jaeger \
46+
opentelemetry-exporter-otlp \
4747
opentelemetry-opencensus-shim \
4848
opentelemetry-instrumentation-sqlite3 \
4949
opencensus \

docs/examples/opencensus-shim/app.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
from opencensus.ext.flask.flask_middleware import FlaskMiddleware
1919

2020
from opentelemetry import trace
21-
from opentelemetry.exporter.jaeger.thrift import JaegerExporter
21+
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import (
22+
OTLPSpanExporter,
23+
)
2224
from opentelemetry.instrumentation.sqlite3 import SQLite3Instrumentor
2325
from opentelemetry.sdk.resources import Resource
2426
from opentelemetry.sdk.trace import TracerProvider
@@ -40,9 +42,8 @@
4042
# Configure OTel to export traces to Jaeger
4143
tracer_provider.add_span_processor(
4244
BatchSpanProcessor(
43-
JaegerExporter(
44-
agent_host_name="localhost",
45-
agent_port=6831,
45+
OTLPSpanExporter(
46+
endpoint="localhost:4317",
4647
)
4748
)
4849
)

docs/examples/opencensus-shim/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
opentelemetry-api
22
opentelemetry-sdk
3-
opentelemetry-exporter-jaeger
3+
opentelemetry-exporter-otlp
44
opentelemetry-opencensus-shim
55
opentelemetry-instrumentation-sqlite3
66
opencensus

docs/examples/opentracing/README.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ Start Jaeger
2626
.. code-block:: sh
2727
2828
docker run --rm \
29-
-p 6831:6831/udp \
30-
-p 6832:6832/udp \
29+
-p 4317:4317 \
30+
-p 4318:4318 \
3131
-p 16686:16686 \
32-
jaegertracing/all-in-one:1.13 \
32+
jaegertracing/all-in-one:latest \
3333
--log-level=debug
3434
3535
Redis
@@ -61,7 +61,7 @@ Alternatively, you can install the Python dependencies separately:
6161
pip install \
6262
opentelemetry-api \
6363
opentelemetry-sdk \
64-
opentelemetry-exporter-jaeger \
64+
opentelemetry-exporter-otlp \
6565
opentelemetry-opentracing-shim \
6666
redis \
6767
redis_opentracing

docs/examples/opentracing/main.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
from rediscache import RedisCache
44

55
from opentelemetry import trace
6-
from opentelemetry.exporter.jaeger.thrift import JaegerExporter
6+
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import (
7+
OTLPSpanExporter,
8+
)
79
from opentelemetry.sdk.trace import TracerProvider
810
from opentelemetry.sdk.trace.export import BatchSpanProcessor
911
from opentelemetry.shim import opentracing_shim
@@ -12,13 +14,16 @@
1214
trace.set_tracer_provider(TracerProvider())
1315
tracer_provider = trace.get_tracer_provider()
1416

15-
# Configure the tracer to export traces to Jaeger
16-
jaeger_exporter = JaegerExporter(
17-
agent_host_name="localhost",
18-
agent_port=6831,
17+
# Create an OTLP gRPC span exporter
18+
otlp_exporter = OTLPSpanExporter(
19+
endpoint="http://localhost:4317",
20+
# For insecure connection, useful for testing
21+
insecure=True,
22+
)
23+
# Add the exporter to the tracer provider
24+
trace.get_tracer_provider().add_span_processor(
25+
BatchSpanProcessor(otlp_exporter)
1926
)
20-
span_processor = BatchSpanProcessor(jaeger_exporter)
21-
tracer_provider.add_span_processor(span_processor)
2227

2328
# Create an OpenTracing shim. This implements the OpenTracing tracer API, but
2429
# forwards calls to the underlying OpenTelemetry tracer.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
opentelemetry-api
22
opentelemetry-sdk
3-
opentelemetry-exporter-jaeger
3+
opentelemetry-exporter-otlp
44
opentelemetry-opentracing-shim
55
redis
66
redis_opentracing

0 commit comments

Comments
 (0)