Merge pull request #64 from adangel/log-exceptions

Log exceptions

Author: jsotuyod

CHANGELOG.md

@@ -7,6 +7,7 @@
 **Fixed issues:**
 
 * [#61](https://github.com/pmd/pmd-designer/issues/61) Remove dependency to jcommander
+* [#62](https://github.com/pmd/pmd-designer/issues/62) Exceptions and errors are not always logged
 * [#63](https://github.com/pmd/pmd-designer/issues/63) Update to PMD 7.0.0-rc3
 
 **Merged pull requests:**

src/main/java/net/sourceforge/pmd/util/fxdesigner/app/ApplicationComponent.java

@@ -4,6 +4,8 @@
 
 package net.sourceforge.pmd.util.fxdesigner.app;
 
+import static net.sourceforge.pmd.util.fxdesigner.util.DesignerUtil.printShortStackTrace;
+
 import java.util.function.Supplier;
 
 import org.checkerframework.checker.nullness.qual.NonNull;
@@ -143,6 +145,7 @@ default void raiseParsableSourceFlag(Supplier<String> details) {
 
     /** Logs an exception that occurred somewhere in the app logic. */
     default void logInternalException(Throwable throwable) {
+        printShortStackTrace(throwable);
         if (isDeveloperMode()) {
             System.err.println("Exception in " + this.getDebugName() + ": " + throwable.getMessage());
             System.err.println("  See the event log for more info");

src/main/java/net/sourceforge/pmd/util/fxdesigner/app/NodeSelectionSource.java

@@ -4,8 +4,6 @@
 
 package net.sourceforge.pmd.util.fxdesigner.app;
 
-import static net.sourceforge.pmd.util.fxdesigner.util.DesignerUtil.printShortStackTrace;
-
 import java.util.Objects;
 
 import org.reactfx.EventStream;
@@ -78,7 +76,6 @@ default Val<Node> initNodeSelectionHandling(DesignerRoot root,
                 Platform.runLater(() -> setFocusNode(evt.selected, evt.options));
             } catch (Exception e) {
                 logInternalException(e);
-                printShortStackTrace(e);
                 // don't rethrow so that an error by one source doesn't affect others
             }
         });

src/main/java/net/sourceforge/pmd/util/fxdesigner/app/services/ASTManagerImpl.java

@@ -129,7 +129,9 @@ public ASTManagerImpl(DesignerRoot owner) {
                           updated = null;
                           currentException.setValue(e);
                       } catch (LinkageError e) {
+                          // LinkageErrors might occur due to API incompatibilities with pmd-core at runtime.
                           updated = null;
+                          logInternalException(e);
                       }
 
                       compilationUnit.setValue(updated);