Skip to content

Commit 4bc0697

Browse files
committed
Fix fat-java build
1 parent cc01037 commit 4bc0697

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ If the `bin` directory of your PMD distribution is on your shell's path, then yo
3232
Alternatively, you can launch the program "from source" with Maven.
3333
* `$ ./mvnw -Prunning exec:java` will launch the program after compiling it, using the JavaFX distribution of your system
3434
* `$ ./mvnw -Prunning,with-javafx exec:java` will also add JavaFX dependencies on your classpath.
35-
You can change the version of those dependencies with eg `-Dopenjfx.version 13` for OpenJFX 13.
35+
You can change the version of those dependencies with eg `-Dopenjfx.version=13` for OpenJFX 13.
3636
See the list of available versions [here](https://search.maven.org/artifact/org.openjfx/javafx).
3737

3838
### Updating
@@ -56,7 +56,7 @@ You can package a runnable jar containing the PMD dependencies with maven. For
5656
now the only option is to build a jar that contains pmd-core and pmd-java:
5757

5858
```
59-
mvn clean package -Dfat-java -Dpmd.core.version=7.0.0-SNAPSHOT
59+
./mvnw clean package -Dfat-java -Dpmd.core.version=7.0.0-SNAPSHOT
6060
```
6161
The `pmd.core.version` property selects the version of pmd-core *and pmd-java*
6262
that will be included. The built jar can then be found in your `target` directory.

pom.xml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,8 +908,20 @@
908908

909909
<!-- Relocate nothing -->
910910

911-
<!-- Merge resource provider files like Ikonli icon resolvers -->
911+
<filters>
912+
<!-- Remove any signed jars signatures -->
913+
<filter>
914+
<artifact>*:*</artifact>
915+
<excludes>
916+
<exclude>META-INF/*.SF</exclude>
917+
<exclude>META-INF/*.DSA</exclude>
918+
<exclude>META-INF/*.RSA</exclude>
919+
</excludes>
920+
</filter>
921+
</filters>
922+
912923
<transformers>
924+
<!-- Merge resource provider files like Ikonli icon resolvers -->
913925
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
914926
</transformers>
915927
</configuration>

0 commit comments

Comments
 (0)