Bump pmd from 6.26.0 to 6.34.0

Author: adangel

pom.xml

@@ -69,7 +69,7 @@
         <surefire.version>3.0.0-M5</surefire.version>
         <checkstyle.version>8.42</checkstyle.version>
         <checkstyle.plugin.version>3.1.2</checkstyle.plugin.version>
-        <pmd.plugin.version>3.13.0</pmd.plugin.version>
+        <pmd.plugin.version>3.14.0</pmd.plugin.version>
         <javadoc.plugin.version>3.0.1</javadoc.plugin.version>
         <source.plugin.version>3.0.1</source.plugin.version>
         <jar.plugin.version>3.1.0</jar.plugin.version>
@@ -78,7 +78,7 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
         <pmd.build-tools.version>12</pmd.build-tools.version>
-        <pmd.check.version>6.26.0</pmd.check.version>
+        <pmd.check.version>6.34.0</pmd.check.version>
 
         <jflex-output>${project.build.directory}/generated-sources/jflex</jflex-output>
 

src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java

@@ -19,6 +19,7 @@
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
+import java.util.Objects;
 import java.util.Stack;
 import java.util.stream.Collectors;
 
@@ -193,7 +194,7 @@ protected void afterChildrenInit() {
         });
 
         if (languageChoicebox.getItems().size() == 1
-            && languageChoicebox.getItems().get(0) == AuxLanguageRegistry.plainTextLanguage()) {
+            && AuxLanguageRegistry.plainTextLanguage().equals(languageChoicebox.getItems().get(0))) {
 
             Platform.runLater(() -> SimplePopups.showStickyNotification(languageChoicebox, AlertType.ERROR,
                                                                         "No pmd language modules on classpath!",
@@ -235,7 +236,7 @@ private void loadSourceFromFile(File file) {
                             "Pick a language?"
                         );
                     }
-                } else if (guess != sourceEditorController.getLanguageVersion()) {
+                } else if (!Objects.equals(guess, sourceEditorController.getLanguageVersion())) {
                     // guess the language from the extension
                     sourceEditorController.setLanguageVersion(guess);
                     SimplePopups.showActionFeedback(

src/main/java/net/sourceforge/pmd/util/fxdesigner/popups/ExportXPathWizardController.java

@@ -139,7 +139,7 @@ public void initialize(URL location, ResourceBundle resources) {
             alert.showAndWait();
 
             exportResultArea.setSyntaxHighlighter(new XmlSyntaxHighlighter());
-            if (alert.getResult() == ButtonType.YES) {
+            if (ButtonType.YES.equals(alert.getResult())) {
                 nameProperty().setValue("");
                 descriptionProperty().setValue("");
                 messageProperty().setValue("");

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/controls/PopOverWrapper.java

@@ -58,7 +58,7 @@ public void showOrFocus(Consumer<@NonNull PopOver> showMethod) {
     }
 
     public void rebind(T identity) {
-        if (identity != this.identity) {
+        if (!Objects.equals(identity, this.identity)) {
             this.identity = identity;
             handleHiding(null);
             preload(() -> rebinder.apply(identity, myPopover.getValue()));