Merge branch 'scrollbars'

Author: oowekyala

src/main/java/net/sourceforge/pmd/util/fxdesigner/SourceEditorController.java

@@ -61,6 +61,7 @@
 
 import javafx.fxml.FXML;
 import javafx.geometry.Insets;
+import javafx.scene.Parent;
 import javafx.scene.control.Alert.AlertType;
 import javafx.scene.control.Button;
 import javafx.scene.control.MenuButton;
@@ -120,6 +121,8 @@ public class SourceEditorController extends AbstractController {
     @FXML
     private NodeEditionCodeArea nodeEditionCodeArea;
     @FXML
+    private Parent codeAreaParent;
+    @FXML
     private NodeParentageCrumbBar focusNodeParentageCrumbBar;
 
     private final PopOverWrapper<LiveTestCase> violationsPopover;
@@ -285,12 +288,12 @@ private void toggleTestEditMode(boolean isTestCaseMode) {
             AnchorPane otherPane = emptyPane();
             testCaseToolsTitledPane.setContent(otherPane);
 
-            otherPane.getChildren().addAll(nodeEditionCodeArea);
+            otherPane.getChildren().addAll(codeAreaParent);
             pane.getChildren().addAll(testCaseToolsTitledPane);
         } else {
             AnchorPane otherPane = emptyPane();
             editorTitledPane.setContent(otherPane);
-            otherPane.getChildren().addAll(nodeEditionCodeArea);
+            otherPane.getChildren().addAll(codeAreaParent);
         }
     }
 

src/main/resources/net/sourceforge/pmd/util/fxdesigner/fxml/editor.fxml

@@ -3,6 +3,7 @@
 <!-- One editor, ie source + ast view + crumb bar -->
 
 
+<?import org.fxmisc.flowless.VirtualizedScrollPane?>
 <?import org.kordamp.ikonli.javafx.FontIcon?>
 <?import net.sourceforge.pmd.util.fxdesigner.util.controls.AstTreeView?>
 <?import net.sourceforge.pmd.util.fxdesigner.util.controls.DynamicWidthChoicebox?>
@@ -71,16 +72,21 @@
                                                 <padding>
                                                     <Insets/>
                                                 </padding>
-                                                <NodeEditionCodeArea fx:id="nodeEditionCodeArea"
-                                                                     stylesheets="@../css/editor-theme.css"
-                                                                     AnchorPane.bottomAnchor="0.0"
-                                                                     AnchorPane.leftAnchor="0.0"
-                                                                     AnchorPane.rightAnchor="0.0"
-                                                                     AnchorPane.topAnchor="0.0">
+                                                <VirtualizedScrollPane
+                                                        fx:id="codeAreaParent"
+                                                        AnchorPane.bottomAnchor="0.0"
+                                                        AnchorPane.leftAnchor="0.0"
+                                                        AnchorPane.rightAnchor="0.0"
+                                                        AnchorPane.topAnchor="0.0">
+                                                    <content>
+                                                        <NodeEditionCodeArea fx:id="nodeEditionCodeArea"
+                                                                             stylesheets="@../css/editor-theme.css">
+                                                        </NodeEditionCodeArea>
+                                                    </content>
                                                     <BorderPane.margin>
                                                         <Insets/>
                                                     </BorderPane.margin>
-                                                </NodeEditionCodeArea>
+                                                </VirtualizedScrollPane>
                                             </AnchorPane>
                                         </content>
                                     </ToolbarTitledPane>

src/main/resources/net/sourceforge/pmd/util/fxdesigner/less/scrolling.less

@@ -53,6 +53,19 @@
   -fx-background-color: white;
 }
 
+.virtualized-scroll-pane  {
+
+  -fx-background-color: #eaeaea;
+
+  & > .scroll-bar {
+    & > .track-background, & > .track {
+      -fx-background-color: #E3E3E3;
+    }
+  }
+}
+
+
+
 
 .no-horizontal-scroll {