Fix deprecation waring in custom rule

Author: oowekyala

config/pmd-check.xml

@@ -72,23 +72,23 @@
                 <value><![CDATA[
 //ClassOrInterfaceBodyDeclaration[Annotation[pmd-java:typeIs('javafx.fxml.FXML')]]
 /FieldDeclaration/VariableDeclarator/VariableDeclaratorId
-                  [not(ends-with(@Image, ../../Type/@TypeImage))]
+                  [not(ends-with(@Name, ../../Type/@TypeImage))]
 
                   (: The following are the exceptions to the rule :)
-                  [not(ends-with(@Image, 'Controller') and ends-with(../../Type/@TypeImage, 'Controller'))]
-                  [not(../../Type/@TypeImage = 'TextField' and ends-with(@Image, 'Field'))]
-                  [not(../../Type/@TypeImage = 'ToggleButton' and ends-with(@Image, 'Toggle'))]
-                  [not(../../Type/@TypeImage = 'TextArea' or ends-with(../../Type/@TypeImage, 'CodeArea') and ends-with(@Image, 'Area'))]
-                  [not(../../Type/@TypeImage = 'TableColumn' and ends-with(@Image, 'Column'))]
-                  [not(../../Type/@TypeImage = 'MenuItem' and ends-with(@Image, 'Button'))]
-                  [not(ends-with(../../Type/@TypeImage, 'Choicebox') and ends-with(@Image, 'Choicebox'))]
-                  [not(ends-with(../../Type/@TypeImage, 'TitledPane') and ends-with(@Image, 'Pane'))]
+                  [not(ends-with(@Name, 'Controller') and ends-with(../../Type/@TypeImage, 'Controller'))]
+                  [not(../../Type/@TypeImage = 'TextField' and ends-with(@Name, 'Field'))]
+                  [not(../../Type/@TypeImage = 'ToggleButton' and ends-with(@Name, 'Toggle'))]
+                  [not(../../Type/@TypeImage = 'TextArea' or ends-with(../../Type/@TypeImage, 'CodeArea') and ends-with(@Name, 'Area'))]
+                  [not(../../Type/@TypeImage = 'TableColumn' and ends-with(@Name, 'Column'))]
+                  [not(../../Type/@TypeImage = 'MenuItem' and ends-with(@Name, 'Button'))]
+                  [not(ends-with(../../Type/@TypeImage, 'Choicebox') and ends-with(@Name, 'Choicebox'))]
+                  [not(ends-with(../../Type/@TypeImage, 'TitledPane') and ends-with(@Name, 'Pane'))]
                   (: This last clause allows variables to be named the same as their type, modulo Camel case :)
                   (: Ideally we would only allow this for our custom types, but there's currently no easy :)
                   (: way to get the type name of a node to check the package. :)
                   (: We should create a function for that, eg typeNameOf :)
-                  [not(string-length(../../Type/@TypeImage) = string-length(@Image)
-                       and substring(../../Type/@TypeImage, 2) = substring(@Image, 2))]
+                  [not(string-length(../../Type/@TypeImage) = string-length(@Name)
+                       and substring(../../Type/@TypeImage, 2) = substring(@Name, 2))]
             ]]></value>
             </property>
         </properties>