Skip to content

Commit 86e2227

Browse files
committed
Fix animation bug on ojfx 13
1 parent c30b4fa commit 86e2227

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

src/main/java/net/sourceforge/pmd/util/fxdesigner/app/services/ASTManagerImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ public ASTManagerImpl(DesignerRoot owner) {
9696
} catch (ParseAbortedException e) {
9797
updated = null;
9898
currentException.setValue(e);
99+
} catch (LinkageError e) {
100+
updated = null;
99101
}
100102

101103
compilationUnit.setValue(updated);

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/controls/MutableTabPane.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ public T addTabWithNewController() {
199199

200200
public void addTabWithController(T controller) {
201201
Tab tab = tabMaker().apply(Objects.requireNonNull(controller));
202+
Objects.requireNonNull(tab, "Null tab?");
202203
addTabAndFocus(tab);
203204
}
204205

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/controls/PopOverWrapper.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,16 @@ private void preload(Supplier<PopOver> supplier) {
8484
public void doFirstLoad(Stage stage) {
8585
myPopover.ifPresent(pop -> {
8686
pop.setOpacity(0);
87+
pop.setAnimated(false);
8788
pop.show(stage, 40000, 40000);
8889

8990
EventStreams.eventsOf(pop, WindowEvent.WINDOW_HIDDEN)
9091
.subscribeForOne(e -> pop.setOpacity(1));
9192

92-
Platform.runLater(pop::hide);
93+
Platform.runLater(() -> {
94+
pop.hide();
95+
pop.setAnimated(true);
96+
});
9397
});
9498
}
9599

0 commit comments

Comments
 (0)