Skip to content

Commit afc1679

Browse files
authored
Bump PMD from 7.8.0 to 7.10.0 for checks (#120)
* Bump PMD from 7.8.0 to 7.10.0 for checks * Add workaround for pmd/pmd#5493
1 parent 5a3f8d4 commit afc1679

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585

8686
<pmd.build-tools.version>29</pmd.build-tools.version>
8787
<pmd.plugin.version>3.26.0</pmd.plugin.version>
88-
<pmd.check.version>7.8.0</pmd.check.version>
88+
<pmd.check.version>7.10.0</pmd.check.version>
8989

9090
<jflex-output>${project.build.directory}/generated-sources/jflex</jflex-output>
9191

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/reactfx/ObservableTickList.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,12 @@ public ObservableTickList(ObservableList<E> base, Function<? super E, ? extends
3333

3434
@Override
3535
protected Subscription observeInputs() {
36-
return ReactfxExtensions.dynamic(base, (e, i) -> ticks.apply(e).subscribe(k -> this.notifyObservers(Collections::emptyList)))
37-
.and(LiveList.observeQuasiChanges(base, this::notifyObservers));
36+
return ReactfxExtensions.dynamic(base, (e, i) -> {
37+
// explicitly using a local var to help PMD, see https://github.com/pmd/pmd/issues/5493
38+
EventStream<?> eventStream = ticks.apply(e);
39+
return eventStream.subscribe(k -> this.notifyObservers(Collections::emptyList));
40+
})
41+
.and(LiveList.observeQuasiChanges(base, this::notifyObservers));
3842
}
3943

4044
}

0 commit comments

Comments
 (0)