Skip to content

Commit be13091

Browse files
committed
Use openjfx 17 by default
Fixes #54
1 parent 2af460d commit be13091

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,17 @@ The maven coordinates (GAV) have been changed. The artifactId has been renamed t
1717

1818
At the same time, the release artefact name changed to **pmd-designer-7.0.0.jar**.
1919

20+
**Changed default OpenJFX version to be 17**
21+
22+
The designer is built now against openjfx 17. When using the designer with OpenJDK, at least Java 11
23+
is required with openjfx 17 or later.
24+
25+
The designer can still be started with Oracle's Java 8, which includes JavaFX. But this is not
26+
explicitly tested.
27+
2028
**Fixed issues:**
2129

30+
* [#54](https://github.com/pmd/pmd-designer/issues/54) Upgrade openjfx to 17
2231
* [#65](https://github.com/pmd/pmd-designer/issues/65) Rename artifactId to pmd-designer
2332

2433
**Merged pull requests:**

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ rules. Main features:
2121
The designer is part of PMD's binary distributions. To install a distribution, see the
2222
[documentation page](https://docs.pmd-code.org/latest/pmd_userdocs_installation.html) about installing PMD.
2323

24-
The app needs JRE 1.8 or above to run. Be aware that on JRE 11+, the JavaFX distribution should be installed
25-
separately. Visit [the download page](https://gluonhq.com/products/javafx/) to download a distribution,
24+
The app needs either Oracle Java 8 (which includes JavaFX) or OpenJDK 11+ and a separately installed
25+
OpenJFX distribution. Visit [JavaFX - Gluon](https://gluonhq.com/products/javafx/) to download an SDK distribution,
2626
extract it, and set the `JAVAFX_HOME` environment variable.
2727

2828
If the `bin` directory of your PMD distribution is on your shell's path, then you can **launch the app** with
@@ -32,7 +32,7 @@ If the `bin` directory of your PMD distribution is on your shell's path, then yo
3232
Alternatively, you can launch the program "from source" with Maven.
3333
* `$ ./mvnw -Prunning exec:java` will launch the program after compiling it, using the JavaFX distribution of your system
3434
* `$ ./mvnw -Prunning,with-javafx exec:java` will also add JavaFX dependencies on your classpath.
35-
You can change the version of those dependencies with eg `-Dopenjfx.version=13` for OpenJFX 13.
35+
You can change the version of those dependencies with eg `-Dopenjfx.version=21.0.2` for OpenJFX 21.
3636
See the list of available versions [here](https://search.maven.org/artifact/org.openjfx/javafx).
3737

3838
### Updating
@@ -62,6 +62,7 @@ The `pmd.core.version` property selects the version of pmd-core *and pmd-java*
6262
that will be included. The built jar can then be found in your `target` directory.
6363
**Such a jar cannot be used in a PMD distribution** and must be used in a
6464
standalone fashion, otherwise classpath conflicts may arise.
65+
You can additionally enable the profile `with-javafx` to include openjfx as well.
6566

6667
You should never run the `install` goal with the `-Dfat-java` property! This
6768
would install the fat jar in your local repo and may cause dependency conflicts.

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
<pmd.designer.version>${project.version}</pmd.designer.version> <!-- see DesignerVersion -->
6060
<pmd.core.version>7.0.0-SNAPSHOT</pmd.core.version>
6161

62-
<openjfx.version>11.0.2</openjfx.version>
62+
<openjfx.version>17.0.10</openjfx.version>
6363
<java.version>8</java.version>
6464
<kotlin.version>1.7.20</kotlin.version>
6565
<kotest.version>5.5.5</kotest.version>

0 commit comments

Comments
 (0)