Skip to content

Commit dc42d24

Browse files
committed
Fix jcommander usage
When using the designer against the latest PMD version (6.27.0), there we provide a older jcommander dependency, which doesn't support the builder yet.
1 parent 61c420f commit dc42d24

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/main/java/net/sourceforge/pmd/util/fxdesigner/DesignerStarter.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,10 @@ private static boolean isJavaFxAvailable() {
3939
private static MainCliArgs readParameters(String[] argv) {
4040

4141
MainCliArgs argsObj = new MainCliArgs();
42+
JCommander jCommander = new JCommander(argsObj);
43+
jCommander.setProgramName("designer");
4244

4345
try {
44-
JCommander jCommander = JCommander.newBuilder()
45-
.programName("designer")
46-
.addObject(argsObj)
47-
.build();
4846
jCommander.parse(argv);
4947

5048
if (argsObj.help) {
@@ -57,7 +55,7 @@ private static MainCliArgs readParameters(String[] argv) {
5755
} catch (ParameterException e) {
5856
System.out.println(e.getMessage());
5957
System.out.println();
60-
System.out.println(getHelpText(e.getJCommander()));
58+
System.out.println(getHelpText(jCommander));
6159
System.exit(OK);
6260
throw new AssertionError();
6361
}
@@ -66,7 +64,6 @@ private static MainCliArgs readParameters(String[] argv) {
6664
}
6765

6866

69-
@SuppressWarnings("PMD.AvoidCatchingThrowable")
7067
public static void main(String[] args) {
7168

7269
readParameters(args);

0 commit comments

Comments
 (0)