Try styling for icons

Author: oowekyala

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/TreeIcons.java

@@ -0,0 +1,42 @@
+/*
+ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
+ */
+
+package net.sourceforge.pmd.util.fxdesigner.util;
+
+import java.util.EnumMap;
+import java.util.Locale;
+
+import org.apache.commons.lang3.StringUtils;
+
+import net.sourceforge.pmd.util.designerbindings.DesignerBindings.TreeIconId;
+
+public final class TreeIcons {
+
+    private static final EnumMap<TreeIconId, String> ICONS_CSS = new EnumMap<>(TreeIconId.class);
+    private static final EnumMap<TreeIconId, String> ICONS_DISPLAY_NAME = new EnumMap<>(TreeIconId.class);
+
+
+    static {
+        for (TreeIconId id : TreeIconId.values()) {
+            String lowerName = id.name().toLowerCase(Locale.ROOT);
+            String idCss = "icon-" + lowerName.replace('_', '-');
+
+            String displayName = StringUtils.capitalize(lowerName) + " declaration";
+
+            ICONS_CSS.put(id, idCss);
+            ICONS_DISPLAY_NAME.put(id, displayName);
+        }
+    }
+
+
+    public static String cssClass(TreeIconId id) {
+        return id == null ? null : ICONS_CSS.get(id);
+    }
+
+
+    public static String displayName(TreeIconId id) {
+        return id == null ? null : ICONS_DISPLAY_NAME.get(id);
+    }
+
+}

src/main/java/net/sourceforge/pmd/util/fxdesigner/util/controls/ASTTreeItem.java

@@ -16,17 +16,22 @@
 import java.util.function.Consumer;
 
 import org.apache.commons.lang3.mutable.MutableInt;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.reactfx.value.Var;
 
 import net.sourceforge.pmd.lang.ast.Node;
 import net.sourceforge.pmd.lang.ast.xpath.Attribute;
 import net.sourceforge.pmd.util.designerbindings.DesignerBindings;
 import net.sourceforge.pmd.util.designerbindings.DesignerBindings.DefaultDesignerBindings;
+import net.sourceforge.pmd.util.designerbindings.DesignerBindings.TreeIconId;
 import net.sourceforge.pmd.util.fxdesigner.app.ApplicationComponent;
 import net.sourceforge.pmd.util.fxdesigner.app.DesignerRoot;
+import net.sourceforge.pmd.util.fxdesigner.util.TreeIcons;
 import net.sourceforge.pmd.util.fxdesigner.util.controls.SearchableTreeView.SearchableTreeItem;
 
+import javafx.scene.control.Tooltip;
 import javafx.scene.control.TreeItem;
+import javafx.scene.text.Text;
 import javafx.scene.text.TextFlow;
 
 /**
@@ -200,7 +205,9 @@ TextFlow styledPresentableText(Node node) {
 
         Attribute attr = bindings.getMainAttribute(node);
 
-        TextFlow flow = new TextFlow(makeStyledText(node.getXPathNodeName(), NODE_XPATH_NAME_CSS));
+        TextFlow flow = new TextFlow();
+        addXPathName(flow, node.getXPathNodeName(), bindings.getIcon(node));
+
         if (attr != null && attr.getStringValue() != null) {
             flow.getChildren().add(makeStyledText(" [", NODE_XPATH_PUNCT_CSS));
             flow.getChildren().add(makeStyledText("@" + attr.getName(), NODE_XPATH_MAIN_ATTR_NAME_CSS));
@@ -212,4 +219,16 @@ TextFlow styledPresentableText(Node node) {
     }
 
 
+    private void addXPathName(TextFlow flow, String name, @Nullable TreeIconId id) {
+        if (id == null) {
+            flow.getChildren().addAll(makeStyledText(name, NODE_XPATH_NAME_CSS));
+        } else {
+            Text headText = new Text(name);
+            headText.getStyleClass().addAll(NODE_XPATH_NAME_CSS, "tree-icon-emphasis", TreeIcons.cssClass(id));
+            Tooltip.install(headText, new Tooltip(TreeIcons.displayName(id)));
+            flow.getChildren().add(headText);
+        }
+    }
+
+
 }

src/main/resources/net/sourceforge/pmd/util/fxdesigner/less/designer.less

@@ -45,6 +45,11 @@
   }
 }
 
+.tree-icon-emphasis {
+  -fx-fill: green;
+  -fx-font-weight: bold;
+}
+
 
 .table-view {
   -fx-border-color: @darker-accent;