Bump build-tools from 30 to 32 (#280)

adangel · web-flow · commit 02f6a396debb · 2025-06-26T16:55:49.000+02:00
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/PMDPlugin.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/PMDPlugin.java
@@ -98,12 +98,12 @@ public class PMDPlugin extends AbstractUIPlugin {
 
     private Map<RGB, Color> coloursByRgb = new HashMap<>();
 
-    private StringTable stringTable; // NOPMD by Herlin on 11/10/06 00:22
+    private StringTable stringTable;
 
     private IPreferencesFactory preferencesFactory = new PreferencesFactoryImpl();
     private IPropertiesFactory propertiesFactory = new PropertiesFactoryImpl();
 
-    private final IRuleSetManager ruleSetManager = new RuleSetManagerImpl(); // NOPMD:SingularField
+    private final IRuleSetManager ruleSetManager = new RuleSetManagerImpl();
 
     private final LogbackConfiguration logbackConfiguration = new LogbackConfiguration();
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/DeleteMarkersCommand.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/DeleteMarkersCommand.java
@@ -28,7 +28,7 @@ public DeleteMarkersCommand() {
         setUserInitiated(false);
     }
 
-    public final void setMarkers(IMarker[] theMarkers) { // NOPMD by Sven on 13.11.06 11:43
+    public final void setMarkers(IMarker[] theMarkers) {
         markers = theMarkers;
     }
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/properties/impl/ProjectPropertiesManagerImpl.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/properties/impl/ProjectPropertiesManagerImpl.java
@@ -348,7 +348,7 @@ private ProjectPropertiesTO fillTransferObject(IProjectProperties projectPropert
 
             for (RuleSet ruleSet : ruleSets) {
                 for (Rule rule : ruleSet.getRules()) {
-                    rules.add(new RuleSpecTO(rule.getName(), rule.getRuleSetName())); // NOPMD:AvoidInstantiatingObjectInLoop
+                    rules.add(new RuleSpecTO(rule.getName(), rule.getRuleSetName()));
                 }
                 for (Pattern pattern : ruleSet.getFileExclusions()) {
                     excludePatterns.add(pattern.pattern());
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java
@@ -50,7 +50,7 @@ public class CPDCheckProjectAction extends AbstractUIAction {
     private static final String CSV_KEY = "CSV";
 
     @Override
-    public void run(final IAction action) { // NOPMD:UnusedFormalParameter
+    public void run(final IAction action) {
         final IWorkbenchPartSite site = targetPartSite();
         final ISelection sel = targetSelection();
         final Shell shell = site.getShell();
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java
@@ -122,7 +122,7 @@ public AbstractPMDRecord getParent() {
      */
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Sven on 13.11.06 11:57
+        return children;
     }
 
     /**
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java
@@ -42,7 +42,7 @@ public AbstractPMDRecord getParent() {
 
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Herlin on 09/10/06 00:22
+        return children;
     }
 
     @Override
@@ -65,12 +65,7 @@ protected final AbstractPMDRecord[] createChildren() {
         try {
             for (IResource member : folder.members()) {
                 if (member != null) {
-                    fileList.add(new FileRecord(member, this)); // NOPMD
-                    // by
-                    // Herlin
-                    // on
-                    // 09/10/06
-                    // 00:25
+                    fileList.add(new FileRecord(member, this));
                 }
             }
         } catch (CoreException ce) {
@@ -115,12 +110,7 @@ public AbstractPMDRecord removeResource(IResource resource) {
             if (file.getResource().equals(resource)) {
                 files.remove(i);
 
-                children = new AbstractPMDRecord[files.size()]; // NOPMD
-                // by
-                // Herlin
-                // on
-                // 09/10/06
-                // 00:31
+                children = new AbstractPMDRecord[files.size()];
                 files.toArray(this.children);
                 removed = true;
                 removedFile = file;
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/MarkerRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/MarkerRecord.java
@@ -64,15 +64,15 @@ public final AbstractPMDRecord[] createChildren() {
 
         while (markerIterator.hasNext()) {
             final MarkerRecord marker = (MarkerRecord) markerIterator.next();
-            children.add(new FileToMarkerRecord(marker)); // NOPMD by Sven on 13.11.06 12:05
+            children.add(new FileToMarkerRecord(marker));
         }
 
         return children.toArray(new AbstractPMDRecord[0]);
     }
 
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Sven on 13.11.06 12:05
+        return children;
     }
 
     @Override
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/PackageRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/PackageRecord.java
@@ -58,7 +58,7 @@ public AbstractPMDRecord getParent() {
 
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Herlin on 09/10/06 00:22
+        return children;
     }
 
     @Override
@@ -89,12 +89,7 @@ protected final AbstractPMDRecord[] createChildren() {
             for (ICompilationUnit javaUnit : javaUnits) {
                 IResource javaResource = javaUnit.getCorrespondingResource();
                 if (javaResource != null) {
-                    fileList.add(new FileRecord(javaResource, this)); // NOPMD
-                    // by
-                    // Herlin
-                    // on
-                    // 09/10/06
-                    // 00:25
+                    fileList.add(new FileRecord(javaResource, this));
                 }
             }
         } catch (CoreException ce) {
@@ -139,12 +134,7 @@ public AbstractPMDRecord removeResource(IResource resource) {
             if (file.getResource().equals(resource)) {
                 files.remove(i);
 
-                children = new AbstractPMDRecord[files.size()]; // NOPMD
-                // by
-                // Herlin
-                // on
-                // 09/10/06
-                // 00:31
+                children = new AbstractPMDRecord[files.size()];
                 files.toArray(this.children);
                 removed = true;
                 removedFile = file;
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/ProjectRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/ProjectRecord.java
@@ -80,7 +80,7 @@ public AbstractPMDRecord getParent() {
 
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Herlin on 09/10/06 00:43
+        return children;
     }
 
     @Override
@@ -187,7 +187,7 @@ protected final Set<FolderRecord> createPackagesFromFolderRoot(IFolder rootFolde
         try {
             for (IResource resource : rootFolder.members()) {
                 if (resource instanceof IFolder) {
-                    folder.add(new FolderRecord((IFolder) resource, this)); // NOPMD
+                    folder.add(new FolderRecord((IFolder) resource, this));
                 }
             }
         } catch (CoreException e) {
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/RootRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/RootRecord.java
@@ -45,7 +45,7 @@ public AbstractPMDRecord getParent() {
 
     @Override
     public AbstractPMDRecord[] getChildren() {
-        return children; // NOPMD by Herlin on 09/10/06 00:56
+        return children;
     }
 
     @Override
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/quickfix/PMDResolutionGenerator.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/quickfix/PMDResolutionGenerator.java
@@ -38,7 +38,7 @@ public class PMDResolutionGenerator implements IMarkerResolutionGenerator {
     private static final Set<String> MISSING_FIXES = new HashSet<>();
     private static final Map<String, String> BROKEN_FIXES = new HashMap<>();
 
-    private static final String QUICKFIX_BUNDLE = "properties.QuickFix"; // NOPMD
+    private static final String QUICKFIX_BUNDLE = "properties.QuickFix";
 
     public static final IMarkerResolution[] EMPTY_RESOLUTIONS = new IMarkerResolution[0];
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViewMemento.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViewMemento.java
@@ -33,7 +33,7 @@
  *
  */
 public class ViewMemento {
-    private final IPath path; // NOPMD by Herlin on 11/10/06 00:15
+    private final IPath path;
     private final File file;
     private XMLMemento memento;
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverview.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverview.java
@@ -2,7 +2,7 @@
  * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
  */
 
-package net.sourceforge.pmd.eclipse.ui.views; // NOPMD by Sven on 13.11.06 11:45
+package net.sourceforge.pmd.eclipse.ui.views;
 
 import java.util.ArrayList;
 import java.util.Arrays;
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewContentProvider.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewContentProvider.java
@@ -333,7 +333,7 @@ public void run() {
     //
     // // if the Project is closed or deleted,
     // // we also delete it from the Model and go on
-    // if (!(project.isOpen() && project.isAccessible())) { // NOPMD by Sven on 09.11.06 22:17
+    // if (!(project.isOpen() && project.isAccessible())) {
     // LOG.debug("The project is not open or not accessible. Remove it");
     // List<AbstractPMDRecord>[] array = updateFiles(project, changedFiles);
     // removals.addAll(array[1]);
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewMenuManager.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewMenuManager.java
@@ -53,7 +53,7 @@ public void setupActions() {
 
         // create the Actions for the PriorityFilter
         for (int i = 0; i < priorities.length; i++) {
-            priorityActions[i] = new PriorityFilterAction(priorities[i], overview); // NOPMD by Herlin on 09/10/06 15:02
+            priorityActions[i] = new PriorityFilterAction(priorities[i], overview);
             priorityActions[i].setChecked(PriorityFilter.getInstance().isPriorityEnabled(priorities[i]));
         }
     }
@@ -148,11 +148,11 @@ private void createProjectFilterMenu(IMenuManager manager) {
             // if the Project contains Errors,
             // we add a FilterAction for it
             if (project.hasMarkers()) {
-                final Action projectFilterAction = new ProjectFilterAction(project, this.overview); // NOPMD by Herlin on 09/10/06 15:03
+                final Action projectFilterAction = new ProjectFilterAction(project, this.overview);
 
                 // if it is not already in the List,
                 // we set it as "visible"
-                if (!projectFilterList.contains(projects[i])) { // NOPMD by Herlin on 09/10/06 15:04
+                if (!projectFilterList.contains(projects[i])) {
                     projectFilterAction.setChecked(true);
                 }
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/cpd/CPDView.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/cpd/CPDView.java
@@ -133,15 +133,15 @@ public void setData(CpdResult result) {
             CpdMatchWithSourceCode data = new CpdMatchWithSourceCode(result, match);
 
             // create a treenode for the match and add to the list
-            TreeNode matchNode = new TreeNode(data); // NOPMD by Sven on 02.11.06 11:27
+            TreeNode matchNode = new TreeNode(data);
             elements.add(matchNode);
 
             // create the children of the match
-            TreeNode[] children = new TreeNode[match.getMarkCount()]; // NOPMD by Sven on 02.11.06 11:28
+            TreeNode[] children = new TreeNode[match.getMarkCount()];
             Iterator<Mark> entryIterator = match.getMarkSet().iterator();
             for (int j = 0; entryIterator.hasNext(); j++) {
                 final CpdMarkWithSourceCode entry = new CpdMarkWithSourceCode(result, entryIterator.next());
-                children[j] = new TreeNode(entry); // NOPMD by Sven on 02.11.06 11:28
+                children[j] = new TreeNode(entry);
                 children[j].setParent(matchNode);
             }
             matchNode.setChildren(children);
diff --git a/pom.xml b/pom.xml
@@ -22,7 +22,7 @@
     <tycho.version>4.0.10</tycho.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <pmd.version>7.14.0</pmd.version>
-    <pmd.build-tools.version>30</pmd.build-tools.version>
+    <pmd.build-tools.version>32</pmd.build-tools.version>
     <checkstyle.version>10.25.1</checkstyle.version>
     <checkstyle.plugin.version>3.6.0</checkstyle.plugin.version>
     <pmd.plugin.version>3.26.0</pmd.plugin.version>

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public DeleteMarkersCommand() {`
`28`	`28`	`setUserInitiated(false);`
`29`	`29`	`}`
`30`	`30`
`31`		`- public final void setMarkers(IMarker[] theMarkers) { // NOPMD by Sven on 13.11.06 11:43`
	`31`	`+ public final void setMarkers(IMarker[] theMarkers) {`
`32`	`32`	`markers = theMarkers;`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ private ProjectPropertiesTO fillTransferObject(IProjectProperties projectPropert`
`348`	`348`
`349`	`349`	`for (RuleSet ruleSet : ruleSets) {`
`350`	`350`	`for (Rule rule : ruleSet.getRules()) {`
`351`		`- rules.add(new RuleSpecTO(rule.getName(), rule.getRuleSetName())); // NOPMD:AvoidInstantiatingObjectInLoop`
	`351`	`+ rules.add(new RuleSpecTO(rule.getName(), rule.getRuleSetName()));`
`352`	`352`	`}`
`353`	`353`	`for (Pattern pattern : ruleSet.getFileExclusions()) {`
`354`	`354`	`excludePatterns.add(pattern.pattern());`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public AbstractPMDRecord getParent() {`
`122`	`122`	`*/`
`123`	`123`	`@Override`
`124`	`124`	`public AbstractPMDRecord[] getChildren() {`
`125`		`- return children; // NOPMD by Sven on 13.11.06 11:57`
	`125`	`+ return children;`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -64,15 +64,15 @@ public final AbstractPMDRecord[] createChildren() {`
`64`	`64`
`65`	`65`	`while (markerIterator.hasNext()) {`
`66`	`66`	`final MarkerRecord marker = (MarkerRecord) markerIterator.next();`
`67`		`- children.add(new FileToMarkerRecord(marker)); // NOPMD by Sven on 13.11.06 12:05`
	`67`	`+ children.add(new FileToMarkerRecord(marker));`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`return children.toArray(new AbstractPMDRecord[0]);`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`@Override`
`74`	`74`	`public AbstractPMDRecord[] getChildren() {`
`75`		`- return children; // NOPMD by Sven on 13.11.06 12:05`
	`75`	`+ return children;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public AbstractPMDRecord getParent() {`
`80`	`80`
`81`	`81`	`@Override`
`82`	`82`	`public AbstractPMDRecord[] getChildren() {`
`83`		`- return children; // NOPMD by Herlin on 09/10/06 00:43`
	`83`	`+ return children;`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`@Override`
`@@ -187,7 +187,7 @@ protected final Set<FolderRecord> createPackagesFromFolderRoot(IFolder rootFolde`
`187`	`187`	`try {`
`188`	`188`	`for (IResource resource : rootFolder.members()) {`
`189`	`189`	`if (resource instanceof IFolder) {`
`190`		`- folder.add(new FolderRecord((IFolder) resource, this)); // NOPMD`
	`190`	`+ folder.add(new FolderRecord((IFolder) resource, this));`
`191`	`191`	`}`
`192`	`192`	`}`
`193`	`193`	`} catch (CoreException e) {`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public AbstractPMDRecord getParent() {`
`45`	`45`
`46`	`46`	`@Override`
`47`	`47`	`public AbstractPMDRecord[] getChildren() {`
`48`		`- return children; // NOPMD by Herlin on 09/10/06 00:56`
	`48`	`+ return children;`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`@Override`