Determine file extensions of the active rule's languages

Skip analysis if extension doesn't match.

Author: adangel

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java

@@ -15,6 +15,7 @@
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 import java.util.Stack;
@@ -72,6 +73,7 @@ public class BaseVisitor {
     private Map<IFile, Set<MarkerInfo2>> accumulator;
     // private PMDEngine pmdEngine;
     private RuleSets ruleSets;
+    private Set<String> fileExtensions;
     private int fileCount;
     private long pmdDuration;
     private IProjectProperties projectProperties;
@@ -225,6 +227,10 @@ public void setRuleSets(final RuleSets ruleSets) {
         this.ruleSets = ruleSets;
     }
 
+    public void setFileExtensions(Set<String> fileExtensions) {
+        this.fileExtensions = fileExtensions;
+    }
+
     /**
      * @return the number of files that has been processed
      */
@@ -264,6 +270,18 @@ protected final void reviewResource(IResource resource) {
             return;
         }
 
+        if (PMDPlugin.getDefault().loadPreferences().isDetermineFiletypesAutomatically()) {
+            if (fileExtensions != null) {
+                if (!fileExtensions.contains(file.getFileExtension().toLowerCase(Locale.ROOT))) {
+                    PMDPlugin.getDefault().logInformation("Skipping file " + file.getName() + " based on file extension");
+                    LOG.debug("Skipping file " + file.getName() + " based on file extension");
+                    return;
+                }
+            } else {
+                LOG.warn("Can't check for file extensions.");
+            }
+        }
+
         Reader input = null;
         try {
             boolean included = isIncluded(file);

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java

@@ -9,6 +9,7 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 
@@ -49,6 +50,7 @@
 import net.sourceforge.pmd.eclipse.runtime.properties.IProjectProperties;
 import net.sourceforge.pmd.eclipse.runtime.properties.PropertiesException;
 import net.sourceforge.pmd.eclipse.ui.actions.RuleSetUtil;
+import net.sourceforge.pmd.lang.Language;
 import net.sourceforge.pmd.util.StringUtil;
 
 /**
@@ -419,6 +421,7 @@ private void processResource(IResource resource) {
             }
 
             RuleSets ruleSets = rulesetsFrom(resource);
+            Set<String> fileExtensions = determineFileExtensions(ruleSets);
             // final PMDEngine pmdEngine = getPmdEngineForProject(project);
             int targetCount = 0;
             if (resource.exists()) {
@@ -432,6 +435,7 @@ private void processResource(IResource resource) {
                     final ResourceVisitor visitor = new ResourceVisitor();
                     visitor.setMonitor(getMonitor());
                     visitor.setRuleSets(ruleSets);
+                    visitor.setFileExtensions(fileExtensions);
                     // visitor.setPmdEngine(pmdEngine);
                     visitor.setAccumulator(markersByFile);
                     visitor.setUseTaskMarker(taskMarker);
@@ -459,6 +463,22 @@ private void processResource(IResource resource) {
         }
     }
 
+    private Set<String> determineFileExtensions(RuleSets ruleSets) {
+        Set<Language> languages = new HashSet<Language>();
+        for (Rule rule : ruleSets.getAllRules()) {
+            languages.add(rule.getLanguage());
+        }
+        Set<String> fileExtensions = new HashSet<String>();
+        for (Language language : languages) {
+            for (String extension : language.getExtensions()) {
+                fileExtensions.add(extension.toLowerCase(Locale.ROOT));
+            }
+        }
+        logInfo("Determined applicable file extensions: " + fileExtensions);
+        LOG.debug("Determined applicable file extensions: " + fileExtensions);
+        return fileExtensions;
+    }
+
     /**
      * Review an entire project
      */
@@ -576,6 +596,7 @@ private void processResourceDelta() {
                     + project.getName());
 
             final RuleSets ruleSets = rulesetsFromResourceDelta();
+            Set<String> fileExtensions = determineFileExtensions(ruleSets);
 
             // PMDEngine pmdEngine = getPmdEngineForProject(project);
             int targetCount = countDeltaElement(resourceDelta);
@@ -587,6 +608,7 @@ private void processResourceDelta() {
                 DeltaVisitor visitor = new DeltaVisitor();
                 visitor.setMonitor(getMonitor());
                 visitor.setRuleSets(ruleSets);
+                visitor.setFileExtensions(fileExtensions);
                 // visitor.setPmdEngine(pmdEngine);
                 visitor.setAccumulator(markersByFile);
                 visitor.setUseTaskMarker(taskMarker);