[ci] Fix publish-release

- use own github app
- fix asset filename

Follow-up on #272 and #277

Author: adangel

.ci/files/prepare_release_notes.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-set -e -o pipefail
+set -e +o pipefail
 
 outfile="release_notes_prepared.md"
 infile="ReleaseNotes.md"
@@ -11,7 +11,13 @@ fi
 
 
 # Extract the release notes.
-# Note: "|| test $? -eq 141" is added to ignore SIGPIPE errors when head finishes before grep is done.
+# Note: with "set +o pipefail", pipe errors are ignored. They might occur when
+# head finishes before grep is done.
+# Error message: "grep: write error: Broken pipe"
+#
+# Note2: "|| test $? -eq 141" is added to ignore SIGPIPE errors when head finishes before grep is done.
+# See https://stackoverflow.com/questions/22464786/ignoring-bash-pipefail-for-error-code-141
+# But that doesn't seem to work.
 BEGIN_LINE=$( (grep -n "^## " "${infile}" || test $? -eq 141) | head -1|cut -d ":" -f 1)
 END_LINE=$( (grep -n "^## " "${infile}" || test $? -eq 141) | head -2|tail -1|cut -d ":" -f 1)
 END_LINE=$((END_LINE - 1))

.github/workflows/publish-release.yml

@@ -145,15 +145,23 @@ jobs:
           name: update-site
       - name: Prepare Release Notes
         run: .ci/files/prepare_release_notes.sh
+        - uses: actions/create-github-app-token@v2
+          id: pmd-actions-helper-app-token
+          with:
+            app-id: ${{ secrets.PMD_ACTIONS_HELPER_ID }}
+            private-key: ${{ secrets.PMD_ACTIONS_HELPER_PRIVATE_KEY }}
+            owner: pmd
+            repositories: pmd-eclipse-plugin
+            permission-contents: write # create a release
       - name: Create Release
         env:
           # Token required for GH CLI:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_TOKEN: ${{ steps.pmd-actions-helper-app-token.outputs.token }}
           TAG_NAME: ${{ github.event.workflow_run.head_branch }}
           VERSION: ${{ needs.check-version.outputs.VERSION }}
         run: |
           RELEASE_NAME="PMD For Eclipse ${VERSION}"
-          gh release create "$TAG_NAME" "net.sourceforge.pmd.eclipse.p2updatesite-${VERSION}.zip" \
+          gh release create "$TAG_NAME" "net.sourceforge.pmd.eclipse.p2updatesite-${TAG_NAME}.zip" \
               --verify-tag \
               --notes-file release_notes_prepared.md \
               --title "$RELEASE_NAME"