Skip to content

Commit 3070dda

Browse files
committed
Fix NPE if file has no extension
1 parent 8d2ffb7 commit 3070dda

File tree

1 file changed

+5
-2
lines changed
  • net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd

1 file changed

+5
-2
lines changed

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,9 @@ public boolean visit(IResource resource) throws CoreException {
332332
if (resource instanceof IFile) {
333333
if (useFileExtensions) {
334334
Set<String> extensions = fileExtensionsPerProject.get(resource.getProject());
335-
if (extensions != null && extensions.contains(resource.getFileExtension().toLowerCase(Locale.ROOT))) {
335+
String extension = resource.getFileExtension();
336+
if (extensions != null && extension != null
337+
&& extensions.contains(extension.toLowerCase(Locale.ROOT))) {
336338
count++;
337339
}
338340
} else {
@@ -777,7 +779,8 @@ private int countResourceElement(IResource resource, Set<String> fileExtensions)
777779

778780
if (resource instanceof IFile) {
779781
if (checkFileExtensions && fileExtensions != null) {
780-
if (fileExtensions.contains(resource.getFileExtension().toLowerCase(Locale.ROOT))) {
782+
String extension = resource.getFileExtension();
783+
if (extension != null && fileExtensions.contains(extension.toLowerCase(Locale.ROOT))) {
781784
return 1;
782785
} else {
783786
return 0;

0 commit comments

Comments
 (0)