Skip to content

Commit 37b5bbd

Browse files
committed
Bug in FileChangeReviewer caused ALL the changes to recalculate about 5 times.
1 parent e83a267 commit 37b5bbd

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/FileChangeReviewer.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import net.sourceforge.pmd.eclipse.runtime.builder.MarkerUtil;
88
import net.sourceforge.pmd.eclipse.runtime.cmd.ReviewCodeCmd;
99

10+
import org.apache.log4j.Logger;
1011
import org.eclipse.core.resources.IFile;
1112
import org.eclipse.core.resources.IResource;
1213
import org.eclipse.core.resources.IResourceChangeEvent;
@@ -110,6 +111,7 @@ private void changed(Set<ResourceChange> itemsChanged, IResourceDelta delta, IPr
110111
if (monitor.isCanceled()) return;
111112
changed(itemsChanged, grandkidDelta, monitor);
112113
}
114+
break;
113115
case IResourceDelta.ADDED :
114116
// if (rsc instanceof IProject) {
115117
// removed(itemsChanged, (IProject)rsc, delta.getFlags());
@@ -121,6 +123,7 @@ private void changed(Set<ResourceChange> itemsChanged, IResourceDelta delta, IPr
121123
if (monitor.isCanceled()) return;
122124
changed(itemsChanged, grandkidDelta, monitor);
123125
}
126+
break;
124127
case IResourceDelta.CHANGED :
125128
// if (rsc instanceof IProject) {
126129
// changed(itemsChanged, (IProject)rsc, delta.getFlags());
@@ -131,7 +134,8 @@ private void changed(Set<ResourceChange> itemsChanged, IResourceDelta delta, IPr
131134
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
132135
if (monitor.isCanceled()) return;
133136
changed(itemsChanged, grandkidDelta, monitor);
134-
}
137+
}
138+
break;
135139
default :
136140
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
137141
if (monitor.isCanceled()) return;

0 commit comments

Comments
 (0)