Manually setup openjdk8 as default vm if it exists

Author: adangel

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/EclipseUtils.java

@@ -35,6 +35,7 @@
 import org.eclipse.jdt.core.IJavaProject;
 import org.eclipse.jdt.core.JavaCore;
 import org.eclipse.jdt.core.JavaModelException;
+import org.eclipse.jdt.launching.JavaRuntime;
 import org.junit.Assert;
 
 import net.sourceforge.pmd.Rule;
@@ -233,7 +234,7 @@ public static void addJavaNature(final IProject project) throws CoreException {
             javaProject
                     .setRawClasspath(
                             new IClasspathEntry[] { JavaCore.newSourceEntry(sourceFolder.getFullPath()),
-                                JavaCore.newContainerEntry(new Path("org.eclipse.jdt.launching.JRE_CONTAINER")) },
+                                JavaRuntime.getDefaultJREContainerEntry() },
                             null);
 
             Hashtable<String, String> javaOptions = JavaCore.getOptions();

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/internal/TestActivator.java

@@ -4,11 +4,19 @@
 
 package net.sourceforge.pmd.eclipse.internal;
 
+import java.io.File;
+import java.io.IOException;
+
+import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
+import org.eclipse.jdt.launching.IVMInstall;
+import org.eclipse.jdt.launching.IVMInstallType;
+import org.eclipse.jdt.launching.JavaRuntime;
 import org.eclipse.ui.plugin.AbstractUIPlugin;
 import org.slf4j.LoggerFactory;
 
+import net.sourceforge.pmd.eclipse.WaitingMonitor;
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
 
 import ch.qos.logback.classic.Level;
@@ -26,7 +34,37 @@ public TestActivator() {
         } else {
             mainPlugin.getLog().log(new Status(IStatus.WARNING, PMDPlugin.PLUGIN_ID, "Couldn't setup logging for tests."));
         }
-        
-    }
 
+        // Setup a default JVM. This is especially required for mac osx on github actions,
+        // as there is no default JVM detected automatically.
+        // This is not done via the following extension, in order to check for the existence of openjdk8Path:
+        /*
+   <extension
+         point="org.eclipse.jdt.launching.vmInstalls">
+      <vmInstall
+            home="${env_var:HOME}/openjdk8"
+            id="net.sourceforge.pmd.eclipse.plugin.test.openjdk8"
+            name="openjdk8"
+            vmInstallType="org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType">
+      </vmInstall>
+   </extension>
+         */
+        File openjdk8Path = new File(System.getProperty("user.home"), "openjdk8");
+        if (openjdk8Path.exists()) {
+            try {
+                openjdk8Path = openjdk8Path.getCanonicalFile();
+                IVMInstallType vmInstallType = JavaRuntime.getVMInstallType("org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType");
+                IVMInstall vm = vmInstallType.createVMInstall("net.sourceforge.pmd.eclipse.plugin.test.openjdk8");
+                vm.setInstallLocation(openjdk8Path);
+                vm.setName("openjdk8");
+                WaitingMonitor monitor = new WaitingMonitor();
+                JavaRuntime.setDefaultVMInstall(vm, monitor);
+                monitor.await();
+            } catch (IOException | CoreException | InterruptedException e) {
+                mainPlugin.getLog().log(new Status(IStatus.ERROR, PMDPlugin.PLUGIN_ID,
+                        "Error setting up default JVM " + openjdk8Path, e));
+                Thread.currentThread().interrupt();
+            }
+        }
+    }
 }