Merge branch 'master' into pk_switch_to_violatoins_overview

Author: Phillip Krall

.travis.yml

@@ -12,9 +12,8 @@ language: java
 jdk: oraclejdk8
 
 before_install:
-  - "mkdir -p $HOME/.m2"
-  - "cp .travis/travis-settings.xml $HOME/.m2/settings.xml"
-  - "source .travis/setup-secrets.sh"
+  - bash .travis/setup-secrets.sh
+  - bash .travis/configure-maven.sh
 install: true
 before_script:
   - "export DISPLAY=:99.0"
@@ -44,6 +43,7 @@ notifications:
   email:
     recipients:
     - [email protected]
+    - [email protected]
     on_success: always
     on_failure: always
 cache:

.travis/configure-maven.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+set -e
+
+mkdir -p ${HOME}/.m2
+cp .travis/travis-settings.xml ${HOME}/.m2/settings.xml

ReleaseNotes.md

@@ -21,6 +21,7 @@ Eclipse Update Site:
 
 *   [#25](https://github.com/pmd/pmd-eclipse-plugin/pull/25): \[core] Typesafe properties - [Clément Fournier](https://github.com/oowekyala)
 *   [#26](https://github.com/pmd/pmd-eclipse-plugin/pull/26): Updated french translations - [Clément Fournier](https://github.com/oowekyala)
+*   [#37](https://github.com/pmd/pmd-eclipse-plugin/pull/37): Global Priority Filter for Violations Overview/Outline - [Phillip Krall](https://github.com/pkrall520)
 
 
 ## 24-June-2017: 4.0.15.v20170624-2134

net.sourceforge.pmd.eclipse.plugin.test.fragment/pom.xml

@@ -12,4 +12,36 @@
   <artifactId>net.sourceforge.pmd.eclipse.plugin.test.fragment</artifactId>
   <packaging>eclipse-plugin</packaging>
 
+  <build>
+    <plugins>
+        <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-checkstyle-plugin</artifactId>
+            <version>3.0.0</version>
+            <executions>
+                <execution>
+                    <id>checkstyle-check</id>
+                    <phase>verify</phase>
+                    <goals>
+                      <goal>check</goal>
+                    </goals>
+                </execution>
+            </executions>
+            <dependencies>
+                <dependency>
+                    <groupId>com.puppycrawl.tools</groupId>
+                    <artifactId>checkstyle</artifactId>
+                    <version>8.8</version>
+                </dependency>
+            </dependencies>
+            <configuration>
+                <configLocation>${basedir}/../pmd-checkstyle-config.xml</configLocation>
+                <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                <sourceDirectories>
+                    <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
+                </sourceDirectories>
+            </configuration>
+        </plugin>
+    </plugins>
+  </build>
 </project>

net.sourceforge.pmd.eclipse.plugin.test.fragment/src/main/java/test/RuleSetsExtension.java

@@ -38,14 +38,14 @@
 
 import java.util.Set;
 
+import org.eclipse.core.runtime.IStatus;
+
 import net.sourceforge.pmd.RuleSet;
 import net.sourceforge.pmd.RuleSetFactory;
 import net.sourceforge.pmd.RuleSetNotFoundException;
 import net.sourceforge.pmd.eclipse.core.IRuleSetsExtension;
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
 
-import org.eclipse.core.runtime.IStatus;
-
 /**
  * Sample of an RuleSets extension.
  * This will automatically registers our fragment rulesets into the core plugin.

net.sourceforge.pmd.eclipse.plugin.test.fragment/src/main/resources/rulesets/extra1.xml

@@ -41,7 +41,7 @@ The Basic Ruleset contains a collection of good practices which everyone should
     </rule>
 
     <rule name="EmptyIfStmt"
-    	  language="java"
+          language="java"
           message="Avoid empty 'if' statements"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -118,7 +118,7 @@ Avoid empty try blocks, they serve no purpose.
     </rule>
 
     <rule name="EmptyFinallyBlock"
-    	  language="java"
+          language="java"
           message="Avoid empty finally blocks"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -148,7 +148,7 @@ Avoid empty finally blocks, these can be deleted.
 
 
     <rule name="EmptySwitchStatements"
-    	  language="java"
+          language="java"
           message="Avoid empty switch statements"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -178,7 +178,7 @@ Avoid empty switch statements.
 
 
     <rule name="JumbledIncrementer"
-    	  language="java"
+          language="java"
          message="Avoid modifying an outer loop incrementer in an inner loop for update expression"
          class="net.sourceforge.pmd.lang.rule.XPathRule">
      <description>
@@ -213,7 +213,7 @@ Avoid jumbled loop incrementers as these are usually a mistake and can make code
 
 
     <rule name="ForLoopShouldBeWhileLoop"
-    	  language="java"
+          language="java"
           message="This for loop could be simplified to a while loop"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -261,7 +261,7 @@ Avoid unnecessary temporaries when converting primitives to Strings
     </rule>
 
     <rule name="OverrideBothEqualsAndHashcode"
-    	  language="java"
+          language="java"
           message="Ensure you override both equals() and hashCode()"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -343,7 +343,7 @@ For more details see http://www.javaworld.com/javaworld/jw-02-2001/jw-0209-doubl
     </rule>
 
     <rule name="ReturnFromFinallyBlock"
-    	  language="java"
+          language="java"
           message="Avoid returning from a finally block"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -376,7 +376,7 @@ For more details see http://www.javaworld.com/javaworld/jw-02-2001/jw-0209-doubl
     </rule>
 
     <rule name="EmptySynchronizedBlock"
-    	  language="java"
+          language="java"
           message="Avoid empty synchronized blocks"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -400,7 +400,7 @@ Avoid empty synchronized blocks as they do nothing.
     </rule>
 
     <rule name="UnnecessaryReturn"
-    	  language="java"
+          language="java"
           message="Avoid unnecessary return statements"
           class="net.sourceforge.pmd.lang.rule.XPathRule">
       <description>
@@ -433,7 +433,7 @@ Avoid unnecessary return statements.
 
 
     <rule name="EmptyStaticInitializer"
-    	  language="java"
+          language="java"
            message="Empty static initializer was found"
            class="net.sourceforge.pmd.lang.rule.XPathRule">
        <description>
@@ -583,9 +583,8 @@ public final class Foo {
 
     // This final modifier is not necessary, since the class is final
     // and thus, all methods are final
-	private final void foo() {
-	}
-
+    private final void foo() {
+    }
 }
 
 ]]>

net.sourceforge.pmd.eclipse.plugin.test/pom.xml

@@ -24,7 +24,6 @@
       <plugin>
         <groupId>org.eclipse.tycho</groupId>
         <artifactId>target-platform-configuration</artifactId>
-        <version>${tycho.version}</version>
         <configuration>
           <dependency-resolution>
             <extraRequirements>
@@ -37,6 +36,34 @@
           </dependency-resolution>
         </configuration>
       </plugin>
+        <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-checkstyle-plugin</artifactId>
+            <version>3.0.0</version>
+            <executions>
+                <execution>
+                    <id>checkstyle-check</id>
+                    <phase>verify</phase>
+                    <goals>
+                      <goal>check</goal>
+                    </goals>
+                </execution>
+            </executions>
+            <dependencies>
+                <dependency>
+                    <groupId>com.puppycrawl.tools</groupId>
+                    <artifactId>checkstyle</artifactId>
+                    <version>8.8</version>
+                </dependency>
+            </dependencies>
+            <configuration>
+                <configLocation>${basedir}/../pmd-checkstyle-config.xml</configLocation>
+                <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                <sourceDirectories>
+                    <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
+                </sourceDirectories>
+            </configuration>
+        </plugin>
     </plugins>
   </build>