PMD Markers are now problem markers

Now they appear in the problem view and
"violationsAsErrors" is working as expected.

Refs #54

Author: adangel

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCmdTest.java

@@ -35,14 +35,19 @@
 package net.sourceforge.pmd.eclipse.runtime.cmd;
 
 import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
 import org.eclipse.core.resources.IFile;
+import org.eclipse.core.resources.IMarker;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IncrementalProjectBuilder;
 import org.eclipse.core.runtime.CoreException;
+import org.eclipse.jdt.internal.core.search.IRestrictedAccessConstructorRequestor;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
@@ -52,6 +57,7 @@
 import net.sourceforge.pmd.RuleSet;
 import net.sourceforge.pmd.eclipse.EclipseUtils;
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
+import net.sourceforge.pmd.eclipse.runtime.PMDRuntimeConstants;
 import net.sourceforge.pmd.eclipse.runtime.properties.IProjectProperties;
 import net.sourceforge.pmd.eclipse.ui.actions.RuleSetUtil;
 
@@ -124,6 +130,17 @@ public void testReviewCmdBasic() throws CommandException, CoreException {
         // We do not test PMD, only a non-empty report is enough
         Assert.assertNotNull(markers);
         Assert.assertTrue("Report size = " + markers.size(), markers.size() > 0);
+
+        // test the marker types - they should be problem markers...
+        final IFile sourceFile = this.testProject.getFile("/src/Test.java");
+        List<IMarker> imarkers = new ArrayList<>();
+        for (String markerType : PMDRuntimeConstants.RULE_MARKER_TYPES) {
+            imarkers.addAll(Arrays.asList(sourceFile.findMarkers(markerType, false, IResource.DEPTH_ONE)));
+        }
+        Assert.assertEquals(markers.get(sourceFile).size(), imarkers.size());
+        for (IMarker marker : imarkers) {
+            Assert.assertTrue(marker.isSubtypeOf(IMarker.PROBLEM));
+        }
     }
 
     /**

net.sourceforge.pmd.eclipse.plugin/plugin.xml

@@ -12,64 +12,53 @@
       </toc>
    </extension>
 
-<!--   original marker
    <extension
          id="pmdMarker"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super
-            type="org.eclipse.core.resources.problemmarker">
-      </super>
-      <persistent
-            value="true">
-      </persistent>
-      <attribute
-            name="rulename">
-      </attribute>
+      <super type="org.eclipse.core.resources.textmarker"></super>
+      <super type="org.eclipse.core.resources.problemmarker"></super>
+      <persistent value="true"></persistent>
+      <attribute name="rulename"></attribute>
    </extension>
--->
 
  <extension
          id="pmdMarker1"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super type="org.eclipse.core.resources.textmarker"></super>
-      <persistent value="true"> </persistent>
-      <attribute  name="rulename">  </attribute>
+      <super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
+      <persistent value="true"></persistent>
    </extension>
 
   <extension
          id="pmdMarker2"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super type="org.eclipse.core.resources.textmarker"></super>
-      <persistent value="true">  </persistent>
-      <attribute name="rulename">  </attribute>
+      <super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
+      <persistent value="true"></persistent>
    </extension>
 
   <extension
          id="pmdMarker3"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super type="org.eclipse.core.resources.textmarker"></super>
-      <persistent value="true">  </persistent>
-      <attribute name="rulename">  </attribute>
+      <super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
+      <persistent value="true"></persistent>
    </extension>
 
   <extension
          id="pmdMarker4"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super type="org.eclipse.core.resources.textmarker"></super>
-      <persistent value="true">  </persistent>
-      <attribute name="rulename">  </attribute>
+      <super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
+      <persistent value="true"></persistent>
    </extension>
 
   <extension
          id="pmdMarker5"
          name="%marker.pmd"
          point="org.eclipse.core.resources.markers">
-      <super type="org.eclipse.core.resources.textmarker"></super>
+      <super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
       <persistent value="true">  </persistent>
       <attribute name="rulename">  </attribute>
    </extension>