Merge branch 'issue-70'

Author: adangel

ReleaseNotes.md

@@ -13,8 +13,12 @@ Eclipse Update Site:
 
 ### Fixed Issues
 
+*   [#70](https://github.com/pmd/pmd-eclipse-plugin/issues/70): UnsupportedOperationException opening Rule Configuration
+
 ### External Contributions
 
+*   [#75](https://github.com/pmd/pmd-eclipse-plugin/pull/75): Prevent UnsupportedOperationException #70
+
 
 ## 20-December-2018: 4.0.18.v20181220-1448
 

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/RuleUIUtilTest.java

@@ -0,0 +1,22 @@
+package net.sourceforge.pmd.eclipse.ui.preferences.br;
+
+import static org.junit.Assert.assertNotNull;
+
+import org.junit.Test;
+
+import net.sourceforge.pmd.Rule;
+import net.sourceforge.pmd.eclipse.ui.IndexedString;
+import net.sourceforge.pmd.lang.rule.XPathRule;
+
+public class RuleUIUtilTest {
+
+    /**
+     * There should be no UnsupportedOperationException...
+     */
+    @Test
+    public void testTndexedPropertyStringFromRule() {
+        Rule rule = new XPathRule();
+        IndexedString s = RuleUIUtil.indexedPropertyStringFrom(rule);
+        assertNotNull(s);
+    }
+}

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/Configuration.java

@@ -1,6 +1,7 @@
 
 package net.sourceforge.pmd.eclipse.ui.preferences.panelmanagers;
 
+import java.util.HashMap;
 import java.util.Map;
 
 import net.sourceforge.pmd.Rule;
@@ -23,7 +24,7 @@ private Configuration() { }
 
     public static Map<PropertyDescriptor<?>, Object> filteredPropertiesOf(PropertySource source) {
 
-        Map<PropertyDescriptor<?>, Object> valuesByProp = source.getPropertiesByPropertyDescriptor();
+        Map<PropertyDescriptor<?>, Object> valuesByProp = new HashMap<>(source.getPropertiesByPropertyDescriptor());
 
         for (PropertyDescriptor<?> excludedRuleProperty : EXCLUDED_RULE_PROPERTIES) {
             valuesByProp.remove(excludedRuleProperty);