Skip to content

Commit 61c188f

Browse files
Phillip KrallPhillip Krall
authored andcommitted
Code clean up
1 parent bccefed commit 61c188f

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/RuleTableViewerSorter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ public void setSortDescending(boolean sortDescending) {
148148
/**
149149
* @return Returns the comparator.
150150
*/
151-
// public Comparator<Rule> getComparator() {
152-
// return comparator;
153-
// }
151+
public Comparator<Rule> getComparator() {
152+
return comparator;
153+
}
154154

155155
/**
156156
* Set a comparator. If the same comparator is already set, then change the

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/PriorityFilterAction.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11

22
package net.sourceforge.pmd.eclipse.ui.views.actions;
33

4-
import org.eclipse.core.resources.IFile;
4+
import org.apache.log4j.Logger;
55
import org.eclipse.jface.action.Action;
66
import org.eclipse.jface.resource.ImageDescriptor;
77
import org.eclipse.jface.viewers.ViewerFilter;
88
import org.eclipse.swt.widgets.Display;
9-
import org.eclipse.ui.IEditorPart;
10-
import org.eclipse.ui.IEditorReference;
11-
import org.eclipse.ui.IWorkbenchPart;
12-
import org.eclipse.ui.PlatformUI;
139

1410
import name.herlin.command.CommandException;
1511
import net.sourceforge.pmd.RulePriority;
@@ -34,6 +30,7 @@ public class PriorityFilterAction extends Action {
3430
private ViolationOverview overviewView;
3531
private PriorityFilter priorityFilter;
3632
private final RulePriority priority;
33+
private static final Logger LOG = Logger.getLogger(PriorityFilterAction.class);
3734

3835
private PriorityFilterAction(ViewerFilter[] filters, RulePriority thePriority) {
3936
priority = thePriority;
@@ -165,7 +162,7 @@ else if (overviewView != null)
165162
try {
166163
ReviewCodeCmd.runCodeReviewOnFiles(PMDPlugin.getDefault().getOpenFiles());
167164
} catch (CommandException e) {
168-
Log.error(e);
165+
LOG.error(e);
169166
}
170167
}
171168

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/PriorityUtil.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@
1919
public class PriorityUtil {
2020

2121
private static PriorityFilter priorityFilter = new PriorityFilter();
22-
static {
23-
UISettings.currentPriorities(true);
24-
}
25-
22+
2623
private PriorityUtil() {
2724
}
2825

0 commit comments

Comments
 (0)