Skip to content

Commit 807cbda

Browse files
committed
Include org.slf4j.log4j in update site
org.slf4j.log4j is included for convenience, so that it doesn't need to be fetched from orbit. In newer eclipse installations, slf4j and logback itself is already installed, only this old log4j dependency is needed. Note: log4j is only needed to provide compatibility, see #112
1 parent 694070a commit 807cbda

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

kepler/kepler.target

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
</location>
1010
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
1111
<repository location="https://archive.eclipse.org/tools/orbit/downloads/drops/R20140114142710/repository/"/>
12-
<unit id="org.apache.log4j" version="1.2.15.v201012070815"/>
13-
<unit id="org.apache.log4j.source" version="1.2.15.v201012070815"/>
1412
<unit id="org.apache.commons.io" version="2.0.1.v201105210651"/>
1513
<unit id="org.apache.commons.io.source" version="2.0.1.v201105210651"/>
1614
<unit id="org.apache.commons.lang" version="2.6.0.v201205030909"/>
@@ -23,6 +21,8 @@
2321
<unit id="ch.qos.logback.slf4j.source" version="1.0.7.v20121108-1250"/>
2422
<unit id="org.slf4j.jul" version="1.7.2.v20121108-1250"/>
2523
<unit id="org.slf4j.jul.source" version="1.7.2.v20121108-1250"/>
24+
<unit id="org.slf4j.log4j" version="1.7.2.v20130115-1340"/>
25+
<unit id="org.slf4j.log4j.source" version="1.7.2.v20130115-1340"/>
2626
</location>
2727
</locations>
2828
<targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.7"/>

net.sourceforge.pmd.eclipse/feature.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,20 @@
3838
install-size="0"
3939
version="4.14.0.qualifier"/>
4040

41+
<!--
42+
org.slf4j.log4j is included for convenience, so that it doesn't need to be fetched from orbit.
43+
Adding it here will add it to the update site of pmd-eclipse-plugin.
44+
45+
In newer eclipse installations, slf4j and logback itself is already installed, only this old log4j
46+
dependency is needed.
47+
48+
Note: log4j is only needed to provide compatibility, see https://github.com/pmd/pmd-eclipse-plugin/pull/112
49+
-->
50+
<plugin
51+
id="org.slf4j.log4j"
52+
download-size="0"
53+
install-size="0"
54+
version="0.0.0"
55+
unpack="false"/>
56+
4157
</feature>

0 commit comments

Comments
 (0)