Remove log4j pom dependency

Note: log4j is still on the plugin requirements in
order to maintain API compatibility.

Author: adangel

ReleaseNotes.md

@@ -20,6 +20,12 @@ This is a bugfix release.
 *   The minimum eclipse version is now definitely Kepler (4.3) as
     it is declared in the market place. This is enforced via a
     target definition.
+*   Usage of Log4j is deprecated and is going to be removed. Logback via slf4j is replacing it.
+    Therefore the following methods/fields are deprecated for removal in `net.sourceforge.pmd.eclipse.runtime.preferences.IPreferences`:
+    *   `getLogLevel()`
+    *   `setLogLevel(Level)`
+    *   `LOG_LEVEL`
+*   `net.sourceforge.pmd.eclipse.plugin.PMDPlugin#ROOT_LOG_ID`
 
 ### External Contributions
 

net.sourceforge.pmd.eclipse.plugin/META-INF/MANIFEST.MF

@@ -42,7 +42,6 @@ Bundle-ClassPath: target/lib/antlr-runtime.jar,
  target/lib/jaxb-impl.jar,
  target/lib/jcommander.jar,
  target/lib/lenses_2.13.jar,
- target/lib/log4j.jar,
  target/lib/parsers_2.13.jar,
  target/lib/pmd-apex-jorje-lib.jar,
  target/lib/pmd-apex.jar,
@@ -175,4 +174,5 @@ Export-Package: name.herlin.command,
  net.sourceforge.pmd.renderers,
  net.sourceforge.pmd.util;uses:="net.sourceforge.pmd.lang.java.ast",
  net.sourceforge.pmd.util.datasource
-Import-Package: org.slf4j
+Import-Package: org.apache.log4j,
+ org.slf4j

net.sourceforge.pmd.eclipse.plugin/pom.xml

@@ -20,11 +20,6 @@
         <version>${pmd.version}</version>
         <type>pom</type>
     </dependency>
-    <dependency>
-        <groupId>log4j</groupId>
-        <artifactId>log4j</artifactId>
-        <version>1.2.17</version>
-    </dependency>
     <dependency>
         <groupId>javax.xml.bind</groupId>
         <artifactId>jaxb-api</artifactId>

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/PMDPlugin.java

@@ -240,7 +240,7 @@ public void start(BundleContext context) throws Exception {
         registerStandardRuleSets();
 
         IPreferences prefs = loadPreferences();
-        logbackConfiguration.applyLogPreferences(prefs.getLogFileName(), prefs.getLogLevel().toString());
+        logbackConfiguration.applyLogPreferences(prefs.getLogFileName(), prefs.getLogLevelName());
         registerAdditionalRuleSets();
         fileChangeListenerEnabled(prefs.isCheckAfterSaveEnabled());
 
@@ -551,7 +551,7 @@ public IRuleSetWriter getRuleSetWriter() {
     }
 
     public void applyLogPreferences(IPreferences preferences) {
-        logbackConfiguration.applyLogPreferences(preferences.getLogFileName(), preferences.getLogLevel().toString());
+        logbackConfiguration.applyLogPreferences(preferences.getLogFileName(), preferences.getLogLevelName());
     }
 
     /**

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/IPreferences.java

@@ -34,7 +34,9 @@ public interface IPreferences {
     boolean REVIEW_PMD_STYLE_ENABLED_DEFAULT = true;
     int MIN_TILE_SIZE_DEFAULT = 25;
     String LOG_FILENAME_DEFAULT = System.getProperty("user.home") + "/pmd-eclipse.log";
+    @Deprecated // use LOG_LEVEL_DEFAULT instead
     Level LOG_LEVEL = Level.WARN;
+    String LOG_LEVEL_DEFAULT = "WARN";
 
     // default renderer
     String ACTIVE_RENDERERS = "text";
@@ -198,7 +200,7 @@ public interface IPreferences {
     int getMinTileSize();
 
     /**
-     * Set the CPD minimul tile size
+     * Set the CPD minimum tile size
      */
     void setMinTileSize(int minTileSize);
 
@@ -214,14 +216,22 @@ public interface IPreferences {
 
     /**
      * Return the log level
+     * @deprecated use {@link #getLogLevelName()}
      */
+    @Deprecated
     Level getLogLevel();
 
+    String getLogLevelName();
+
     /**
      * Set the log level
+     * @deprecated use {@link #setLogLevel(String)}
      */
+    @Deprecated
     void setLogLevel(Level level);
 
+    void setLogLevel(String level);
+
     // Globally configured rules
 
     // later...

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/impl/PreferencesImpl.java

@@ -44,7 +44,7 @@ class PreferencesImpl implements IPreferences {
     private boolean reviewPmdStyleEnabled;
     private int minTileSize;
     private String logFileName;
-    private Level logLevel;
+    private String logLevel;
     private boolean globalRuleManagement;
     private Set<String> activeRuleNames = new HashSet<String>();
     private Set<String> activeRendererNames = new HashSet<String>();
@@ -209,7 +209,14 @@ public String getLogFileName() {
     /**
      * @see net.sourceforge.pmd.eclipse.runtime.preferences.IPreferences#getLogLevel()
      */
+    @Deprecated
+    @Override
     public Level getLogLevel() {
+        return Level.toLevel(logLevel);
+    }
+
+    @Override
+    public String getLogLevelName() {
         return logLevel;
     }
 
@@ -223,7 +230,14 @@ public void setLogFileName(String logFileName) {
     /**
      * @see net.sourceforge.pmd.eclipse.runtime.preferences.IPreferences#setLogLevel(org.apache.log4j.Level)
      */
+    @Deprecated
+    @Override
     public void setLogLevel(Level level) {
+        logLevel = level.toString();
+    }
+
+    @Override
+    public void setLogLevel(String level) {
         logLevel = level;
     }
 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/impl/PreferencesManagerImpl.java

@@ -19,7 +19,6 @@
 import java.util.Set;
 
 import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Level;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IWorkspaceRoot;
 import org.eclipse.core.resources.ResourcesPlugin;
@@ -336,8 +335,8 @@ private void loadLogFileName() {
     }
 
     private void loadLogLevel() {
-        loadPreferencesStore.setDefault(LOG_LEVEL, IPreferences.LOG_LEVEL.toString());
-        preferences.setLogLevel(Level.toLevel(loadPreferencesStore.getString(LOG_LEVEL)));
+        loadPreferencesStore.setDefault(LOG_LEVEL, IPreferences.LOG_LEVEL_DEFAULT);
+        preferences.setLogLevel(loadPreferencesStore.getString(LOG_LEVEL));
     }
 
     private void loadGlobalRuleManagement() {
@@ -521,7 +520,7 @@ private void storeLogFileName() {
     }
 
     private void storeLogLevel() {
-        storePreferencesStore.setValue(LOG_LEVEL, preferences.getLogLevel().toString());
+        storePreferencesStore.setValue(LOG_LEVEL, preferences.getLogLevelName());
     }
 
     private void storePriorityDescriptors() {