Skip to content

Commit 937d4f5

Browse files
authored
chore: Improve do-release.sh (#291)
- Add a safety question whether a new pmd language module would need to be included - Build the plugin with "-U" locally, so that fetching a new PMD version won't fail. Locally, maven could have tried to fetch it before it was available in central and remembered that the new PMD version is not there.
1 parent 4a92814 commit 937d4f5

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

ReleaseNotes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This is a minor release.
1717

1818
### ✨ Merged pull requests
1919
* [#290](https://github.com/pmd/pmd-eclipse-plugin/pull/290): chore: Add pmd-css - [Andreas Dangel](https://github.com/adangel) (@adangel)
20+
* [#291](https://github.com/pmd/pmd-eclipse-plugin/pull/291): chore: Improve do-release.sh - [Andreas Dangel](https://github.com/adangel) (@adangel)
2021

2122
### 📦 Dependency updates
2223

do-release.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,14 @@ echo
6868
echo "Press enter to continue... (or CTRL+C to cancel)"
6969
read -r
7070

71+
echo
72+
echo "Has the PMD version been upgraded? Did this version introduce a new language?"
73+
echo "If yes, then update net.sourceforge.pmd.eclipse.plugin/META-INF/MANIFEST.MF and"
74+
echo "net.sourceforge.pmd.eclipse.plugin/build.properties to add the new pmd module jar."
75+
echo
76+
echo "Press enter to continue... (or CTRL+C to cancel)"
77+
read -r
78+
7179
echo Update the ReleaseNotes with the release date and version:
7280
echo
7381
echo "## $(date -u +%d-%B-%Y): ${RELEASE_VERSION}.${BUILDQUALIFIER}"
@@ -121,7 +129,7 @@ echo
121129
echo Checkout the release branch and build the plugin
122130
git checkout "pmd-eclipse-plugin-rb-${RELEASE_VERSION}"
123131

124-
./mvnw clean verify
132+
./mvnw clean verify -U
125133

126134
# extract the release notes
127135
BEGIN_LINE=$(grep -n "^## " ReleaseNotes.md|head -1|cut -d ":" -f 1)

0 commit comments

Comments
 (0)