Fixes #103: IllegalStateException: Must be called in the UI thread

Author: adangel

ReleaseNotes.md

@@ -13,6 +13,8 @@ Eclipse Update Site:
 
 ### Fixed Issues
 
+*   [#103](https://github.com/pmd/pmd-eclipse-plugin/issues/103): IllegalStateException: Must be called in the UI thread
+
 ### API Changes
 
 ### External Contributions

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/ShapePainter.java

@@ -4,7 +4,6 @@
 
 package net.sourceforge.pmd.eclipse.ui;
 
-import org.eclipse.swt.SWT;
 import org.eclipse.swt.graphics.GC;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.graphics.ImageData;
@@ -19,6 +18,8 @@
  *
  */
 public class ShapePainter {
+    private static final RGB RGB_BLACK = new RGB(0, 0, 0);
+
     private ShapePainter() {
     }
 
@@ -35,7 +36,7 @@ public static Image newDrawnImage(Display display, int width, int height, Shape
         gc.setBackground(PMDPlugin.getDefault().colorFor(transparentColour));
         gc.fillRectangle(0, 0, width, height);
 
-        gc.setForeground(display.getSystemColor(SWT.COLOR_BLACK));
+        gc.setForeground(PMDPlugin.getDefault().colorFor(RGB_BLACK));
         gc.setBackground(PMDPlugin.getDefault().colorFor(fillColour));
 
         drawShape(width - 1, height - 1, shape, gc, 0, 0, null);

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/priority/PriorityDescriptor.java

@@ -239,13 +239,9 @@ public void dispose() {
     }
 
     /**
-     * Eagerly create the images. This must be called in a UI thread!
+     * Eagerly create the images.
      */
     public void refreshImages() {
-        if (Display.getCurrent() == null) {
-            throw new IllegalStateException("Must be called in the UI thread");
-        }
-
         dispose();
         Image image = getAnnotationImage();
         if (image == null) {