Remove classes related to old RuleDialog Fix PMD unused constants

Author: adangel

ReleaseNotes.md

@@ -17,6 +17,16 @@ This is a minor release.
 
 ### API Changes
 
+The following classes have finally been removed. Most of them have been deprecated before:
+* net.sourceforge.pmd.eclipse.ui.preferences.PMDPreferencePage
+* net.sourceforge.pmd.eclipse.ui.preferences.RuleCellModifier
+* net.sourceforge.pmd.eclipse.ui.preferences.RuleDialog
+* net.sourceforge.pmd.eclipse.ui.preferences.RulePropertyCellModifier (was not deprecated)
+* net.sourceforge.pmd.eclipse.ui.preferences.RuleSetExcludeIncludePatternCellModifier (was not deprecated)
+* net.sourceforge.pmd.eclipse.ui.properties.PMDPropertyPage
+* net.sourceforge.pmd.eclipse.ui.views.actions.ShowRuleAction (was not deprecated)
+* net.sourceforge.pmd.eclipse.ui.views.rules.RuleEditorView
+
 ### External Contributions
 
 ## 02-May-2023: 7.0.0.v20230502-1028-rc2

net.sourceforge.pmd.eclipse.plugin/plugin.xml

@@ -303,10 +303,6 @@
                id="net.sourceforge.pmd.eclipse.ui.keywords.pmd">
          </keywordReference>
       </page>
-<!--
-      <page name="PMD - Original" category="net.sourceforge.pmd.ui.preferences.generalPreferencesPage" class="net.sourceforge.pmd.eclipse.ui.preferences.PMDPreferencePage" id="net.sourceforge.pmd.ui.preferences.pmdPreferencePage">
-      </page>
--->
       <page
             name="%preferences.cpd"
             category="net.sourceforge.pmd.eclipse.ui.preferences.generalPreferencesPage"

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/GeneralPreferencesPage.java

@@ -62,6 +62,7 @@
 import net.sourceforge.pmd.eclipse.ui.model.RootRecord;
 import net.sourceforge.pmd.eclipse.ui.nls.StringKeys;
 import net.sourceforge.pmd.eclipse.ui.preferences.br.BasicTableManager;
+import net.sourceforge.pmd.eclipse.ui.preferences.br.PMDPreferencePage2;
 import net.sourceforge.pmd.eclipse.ui.priority.PriorityColumnUI;
 import net.sourceforge.pmd.eclipse.ui.priority.PriorityDescriptor;
 import net.sourceforge.pmd.eclipse.ui.priority.PriorityDescriptorCache;
@@ -71,7 +72,7 @@
  * The top-level page for PMD preferences
  *
  * @see CPDPreferencePage
- * @see PMDPreferencePage
+ * @see PMDPreferencePage2
  *
  * @author Philippe Herlin
  * @author Brian Remedios