Do not rerun PMD when the priority filter is changed

Now only ViolationOutline/ViolationOverview reflect the
priority filter

Author: adangel

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/PMDPlugin.java

@@ -265,7 +265,9 @@ public void resourceChanged(IResourceChangeEvent arg0) {
      * Get a list of all the files that are open in eclipse currently
      * 
      * @return
+     * @deprecated will be removed since it is not needed
      */
+    @Deprecated
     public Set<IFile> getOpenFiles() {
         Set<IFile> files = new HashSet<IFile>();
         IEditorReference[] refs = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage()
@@ -279,7 +281,7 @@ public Set<IFile> getOpenFiles() {
         }
         return files;
     }
-    
+
     /**
      * Open a view to the id passed in.
      * 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java

@@ -47,7 +47,6 @@
 import net.sourceforge.pmd.eclipse.runtime.properties.IProjectProperties;
 import net.sourceforge.pmd.eclipse.runtime.properties.PropertiesException;
 import net.sourceforge.pmd.eclipse.util.IOUtil;
-import net.sourceforge.pmd.eclipse.util.PriorityUtil;
 import net.sourceforge.pmd.lang.LanguageRegistry;
 import net.sourceforge.pmd.lang.LanguageVersion;
 import net.sourceforge.pmd.lang.LanguageVersionDiscoverer;
@@ -521,11 +520,6 @@ private void updateMarkers(IFile file, Iterator<RuleViolation> violations, boole
             review.ruleName = rule.getName();
             review.lineNumber = violation.getBeginLine();
 
-            /* Only show active violations */
-            if (!PriorityUtil.isPriorityActive(rule.getPriority())) {
-                continue;
-            }
-
             if (reviewsList.contains(review)) {
                 LOG.debug("Ignoring violation of rule " + rule.getName() + " at line " + violation.getBeginLine()
                         + " because of a review.");

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/PriorityFilter.java

@@ -184,31 +184,47 @@ public List<Integer> getPriorityFilterList() {
         return priorityList;
     }
 
+    public void enablePriority(RulePriority priority) {
+        if (priority != null) {
+            if (enabledPriorities.add(priority)) {
+                notifyPriorityEnabled(priority);
+            }
+        }
+    }
+
+    public void disablePriority(RulePriority priority) {
+        if (priority != null) {
+            if (enabledPriorities.remove(priority)) {
+                notifyPriorityDisabled(priority);
+            }
+        }
+    }
+
     /**
      * Adds a Priority to The List
      *
      * @param priority
+     * @deprecated use {@link #enablePriority(RulePriority)}
      */
+    @Deprecated
     public void addPriorityToList(Integer priority) {
         if (priority != null) {
             RulePriority rulePriority = RulePriority.valueOf(priority);
-            if (enabledPriorities.add(rulePriority)) {
-                notifyPriorityEnabled(rulePriority);
-            }
+            enablePriority(rulePriority);
         }
     }
 
     /**
      * Removes a Priority From the List
      *
      * @param priority
+     * @deprecated use {@link #disablePriority(RulePriority)}
      */
+    @Deprecated
     public void removePriorityFromList(Integer priority) {
         if (priority != null) {
             RulePriority rulePriority = RulePriority.valueOf(priority);
-            if (enabledPriorities.remove(rulePriority)) {
-                notifyPriorityDisabled(rulePriority);
-            }
+            disablePriority(rulePriority);
         }
     }
 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/PriorityFilterAction.java

@@ -4,21 +4,18 @@
 
 package net.sourceforge.pmd.eclipse.ui.views.actions;
 
-import org.apache.log4j.Logger;
 import org.eclipse.jface.action.Action;
 import org.eclipse.jface.resource.ImageDescriptor;
 import org.eclipse.jface.viewers.ViewerFilter;
 
 import net.sourceforge.pmd.RulePriority;
-import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
 import net.sourceforge.pmd.eclipse.plugin.UISettings;
-import net.sourceforge.pmd.eclipse.runtime.cmd.ReviewCodeCmd;
 import net.sourceforge.pmd.eclipse.ui.priority.PriorityDescriptor;
 import net.sourceforge.pmd.eclipse.ui.priority.PriorityDescriptorCache;
 import net.sourceforge.pmd.eclipse.ui.views.PriorityFilter;
+import net.sourceforge.pmd.eclipse.ui.views.PriorityFilter.PriorityFilterChangeListener;
 import net.sourceforge.pmd.eclipse.ui.views.ViolationOutline;
 import net.sourceforge.pmd.eclipse.ui.views.ViolationOverview;
-import net.sourceforge.pmd.eclipse.ui.views.PriorityFilter.PriorityFilterChangeListener;
 
 /**
  * Filters elements by the Marker priorities
@@ -32,7 +29,6 @@ public class PriorityFilterAction extends Action implements PriorityFilterChange
     private ViolationOverview overviewView;
     private PriorityFilter priorityFilter;
     private final RulePriority priority;
-    private static final Logger LOG = Logger.getLogger(PriorityFilterAction.class);
 
     private PriorityFilterAction(ViewerFilter[] filters, RulePriority thePriority) {
         priority = thePriority;
@@ -102,36 +98,33 @@ public void run() {
         // we add or remove an Integer with the Priority to a List
         // of Priorities, the Filter does the Rest
         if (isChecked()) {
-            priorityFilter.addPriorityToList(priority.getPriority());
+            priorityFilter.enablePriority(priority);
         } else {
-            priorityFilter.removePriorityFromList(priority.getPriority());
+            priorityFilter.disablePriority(priority);
         }
+    }
 
+    private void refreshView() {
         if (outlineView != null) {
             outlineView.refresh();
         } else if (overviewView != null) {
             overviewView.refresh();
         }
-
-        /* Get all the opened files and tell them to run a "review code" on the file */
-        try {
-            ReviewCodeCmd.runCodeReviewOnFiles(PMDPlugin.getDefault().getOpenFiles());
-        } catch (RuntimeException e) {
-            LOG.error(e);
-        }
     }
 
     @Override
     public void priorityEnabled(RulePriority priority) {
         if (this.priority == priority) {
             this.setChecked(true);
+            refreshView();
         }
     }
 
     @Override
     public void priorityDisabled(RulePriority priority) {
         if (this.priority == priority) {
             this.setChecked(false);
+            refreshView();
         }
     }
 }