Skip to content

Commit adb3cb2

Browse files
committed
Merge branch 'pr-44'
2 parents 4918c57 + ae72bd3 commit adb3cb2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ReleaseNotes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ Eclipse Update Site:
3737
* [#39](https://github.com/pmd/pmd-eclipse-plugin/pull/39): Show PMD violations overview/outline views when checking code - [Phillip Krall](https://github.com/pkrall520)
3838
* [#40](https://github.com/pmd/pmd-eclipse-plugin/pull/40): Only execute PMD when check on save is enabled - [Phillip Krall](https://github.com/pkrall520)
3939
* [#41](https://github.com/pmd/pmd-eclipse-plugin/pull/41): Update all views after marker color changed - [Phillip Krall](https://github.com/pkrall520)
40+
* [#44](https://github.com/pmd/pmd-eclipse-plugin/pull/44): Fix saving preferences for violation overview/outline - [Phillip Krall](https://github.com/pkrall520)
4041

4142

4243
## 24-June-2017: 4.0.15.v20170624-2134

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/impl/PreferencesManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ private void initLoadPreferencesStore() {
239239
*/
240240
public void storePreferences(IPreferences thePreferences) {
241241
preferences = thePreferences;
242-
242+
243243
storeProjectBuildPathEnabled();
244244
storePmdPerspectiveEnabled();
245245
storePmdViolationsOverviewEnabled();
@@ -292,12 +292,12 @@ private void loadPmdPerspectiveEnabled() {
292292

293293
private void loadPmdViolationsOverviewEnabled() {
294294
loadPreferencesStore.setDefault(PMD_VIOLATIONS_OVERVIEW_ENABLED, IPreferences.PMD_VIOLATIONS_OVERVIEW_ENABLED_DEFAULT);
295-
preferences.setPmdPerspectiveEnabled(loadPreferencesStore.getBoolean(PMD_VIOLATIONS_OVERVIEW_ENABLED));
295+
preferences.setPmdViolationsOverviewEnabled(loadPreferencesStore.getBoolean(PMD_VIOLATIONS_OVERVIEW_ENABLED));
296296
}
297297

298298
private void loadPmdViolationsOutlineEnabled() {
299299
loadPreferencesStore.setDefault(PMD_VIOLATIONS_OUTLINE_ENABLED, IPreferences.PMD_VIOLATIONS_OUTLINE_ENABLED_DEFAULT);
300-
preferences.setPmdPerspectiveEnabled(loadPreferencesStore.getBoolean(PMD_VIOLATIONS_OUTLINE_ENABLED));
300+
preferences.setPmdViolationsOutlineEnabled(loadPreferencesStore.getBoolean(PMD_VIOLATIONS_OUTLINE_ENABLED));
301301
}
302302

303303
private void loadCheckAfterSaveEnabled() {

0 commit comments

Comments
 (0)