SWTError: No more handles

Fixes #116

Author: adangel

ReleaseNotes.md

@@ -15,6 +15,7 @@ Eclipse Update Site:
 
 *   [#114](https://github.com/pmd/pmd-eclipse-plugin/issues/114): NPE in PriorityDescriptorCache
 *   [#115](https://github.com/pmd/pmd-eclipse-plugin/issues/115): Missing dependencies when installing
+*   [#116](https://github.com/pmd/pmd-eclipse-plugin/issues/116): SWTError: No more handles
 
 ### API Changes
 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/RootRecord.java

@@ -73,7 +73,9 @@ protected final AbstractPMDRecord[] createChildren() {
 
         // ... and create Records for them
         for (IProject project : projects) {
-            projectList.add(new ProjectRecord(project, this));
+            if (project.isOpen()) {
+                projectList.add(new ProjectRecord(project, this));
+            }
         }
 
         // return the Array of children

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverview.java

@@ -175,6 +175,8 @@ public void dispose() {
 
         memento.save();
 
+        menuManager.dispose();
+
         super.dispose();
     }
 
@@ -414,7 +416,7 @@ public void refresh() {
 
     public void refreshMenu() {
         menuManager.createDropDownMenu(getViewSite().getActionBars().getMenuManager());
-        menuManager.createContextMenu();
+        // note: the context menu doesn't need to be refreshed
     }
 
     /**

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewContentProvider.java

@@ -303,8 +303,7 @@ public void resourceChanged(IResourceChangeEvent event) {
         final ChangeRecord<AbstractPMDRecord> changes = changeEvaluator.changeRecordFor(event);
 
         // the additions, removals and changes are given to the viewer so that it can update itself
-        // updating the table MUST be in sync
-        treeViewer.getControl().getDisplay().syncExec(new Runnable() {
+        treeViewer.getControl().getDisplay().asyncExec(new Runnable() {
             public void run() {
                 updateViewer(changes);
             }

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ViolationOverviewMenuManager.java

@@ -15,6 +15,7 @@
 import org.eclipse.jface.action.Separator;
 import org.eclipse.swt.widgets.Tree;
 import org.eclipse.ui.IWorkbenchActionConstants;
+import org.eclipse.ui.services.IDisposable;
 
 import net.sourceforge.pmd.RulePriority;
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
@@ -35,9 +36,10 @@
  *
  */
 
-public class ViolationOverviewMenuManager {
+public class ViolationOverviewMenuManager implements IDisposable {
     private final ViolationOverview overview;
     private PriorityFilterAction[] priorityActions;
+    private MenuManager contextMenuManager;
 
     public ViolationOverviewMenuManager(ViolationOverview overview) {
         this.overview = overview;
@@ -92,40 +94,42 @@ public void createDropDownMenu(IMenuManager manager) {
      * Creates the Context Menu
      */
     public void createContextMenu() {
-        MenuManager manager = new MenuManager();
-        manager.setRemoveAllWhenShown(true);
-        manager.addMenuListener(new IMenuListener() {
-            public void menuAboutToShow(IMenuManager manager) {
-                MenuManager submenuManager;
-
-                // one SubMenu for filtering Projects
-                submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_RESOURCE_FILTER));
-                createProjectFilterMenu(submenuManager);
-                manager.add(submenuManager);
-
-                // ... another one for filtering Priorities
-                submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_PRIORITY_FILTER));
-                for (PriorityFilterAction priorityAction : priorityActions) {
-                    submenuManager.add(priorityAction);
-                }
-                manager.add(submenuManager);
-
-                // ... another one for showing the presentation types
-                submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_PRESENTATION_TYPE));
-                createShowTypeSubmenu(submenuManager);
-                manager.add(submenuManager);
-
-                // additions Action: Clear PMD Violations
-                manager.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
-                manager.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS + "-end"));
+        if (contextMenuManager == null) {
+            contextMenuManager = new MenuManager();
+            contextMenuManager.setRemoveAllWhenShown(true);
+            contextMenuManager.addMenuListener(new IMenuListener() {
+                public void menuAboutToShow(IMenuManager manager) {
+                    MenuManager submenuManager;
+
+                    // one SubMenu for filtering Projects
+                    submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_RESOURCE_FILTER));
+                    createProjectFilterMenu(submenuManager);
+                    manager.add(submenuManager);
+
+                    // ... another one for filtering Priorities
+                    submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_PRIORITY_FILTER));
+                    for (PriorityFilterAction priorityAction : priorityActions) {
+                        submenuManager.add(priorityAction);
+                    }
+                    manager.add(submenuManager);
+
+                    // ... another one for showing the presentation types
+                    submenuManager = new MenuManager(getString(StringKeys.VIEW_MENU_PRESENTATION_TYPE));
+                    createShowTypeSubmenu(submenuManager);
+                    manager.add(submenuManager);
+
+                    // additions Action: Clear PMD Violations
+                    manager.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
+                    manager.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS + "-end"));
 
-            }
-        });
+                }
+            });
+        }
 
         Tree tree = overview.getViewer().getTree();
-        tree.setMenu(manager.createContextMenu(tree));
+        tree.setMenu(contextMenuManager.createContextMenu(tree));
 
-        overview.getSite().registerContextMenu(manager, overview.getViewer());
+        overview.getSite().registerContextMenu(contextMenuManager, overview.getViewer());
     }
 
     /**
@@ -178,4 +182,12 @@ private void createShowTypeSubmenu(IMenuManager manager) {
     private String getString(String key) {
         return PMDPlugin.getDefault().getStringTable().getString(key);
     }
+
+    @Override
+    public void dispose() {
+        if (contextMenuManager != null) {
+            contextMenuManager.dispose();
+            contextMenuManager = null;
+        }
+    }
 }