Fix NPE when validating rule class type

adangel · adangel · commit bcb7f9816c26 · 2024-04-19T11:36:11.000+02:00
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/RulePanelManager.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/RulePanelManager.java
@@ -642,7 +642,7 @@ private boolean hasValidRuleType() {
         } catch (ClassNotFoundException e) {
             PMDPlugin.getDefault().logError("Couldn't find rule impl class " + newType, e);
         }
-        return newType != null && Rule.class.isAssignableFrom(newTypeClass);
+        return newTypeClass != null && Rule.class.isAssignableFrom(newTypeClass);
     }
 
     private String nameFieldValue() {

Original file line number	Diff line number	Diff line change
`@@ -642,7 +642,7 @@ private boolean hasValidRuleType() {`
`642`	`642`	`} catch (ClassNotFoundException e) {`
`643`	`643`	`PMDPlugin.getDefault().logError("Couldn't find rule impl class " + newType, e);`
`644`	`644`	`}`
`645`		`- return newType != null && Rule.class.isAssignableFrom(newTypeClass);`
	`645`	`+ return newTypeClass != null && Rule.class.isAssignableFrom(newTypeClass);`
`646`	`646`	`}`
`647`	`647`
`648`	`648`	`private String nameFieldValue() {`