Skip to content

Commit e46c67e

Browse files
adangeladangel
committed
whitespaces, formatting
1 parent b06105e commit e46c67e

File tree

3 files changed

+632
-599
lines changed

3 files changed

+632
-599
lines changed

‎net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/FileChangeReviewer.java‎

Lines changed: 154 additions & 145 deletions
Original file line numberDiff line numberDiff line change
@@ -19,155 +19,164 @@
1919
import org.eclipse.core.runtime.NullProgressMonitor;
2020

2121
/**
22-
* Monitors for changes in the workspace and initiates the ReviewCodeCmd
23-
* when suitable file changes in some meaningful way.
22+
* Monitors for changes in the workspace and initiates the ReviewCodeCmd when
23+
* suitable file changes in some meaningful way.
2424
*
2525
* @author Brian Remedios
2626
*/
2727
public class FileChangeReviewer implements IResourceChangeListener {
2828

29-
public FileChangeReviewer() {
30-
}
31-
32-
private enum ChangeType {
33-
ADDED,
34-
REMOVED,
35-
CHANGED
36-
}
37-
38-
private class ResourceChange {
39-
public final ChangeType resourceDeltaType;
40-
public final int flags;
41-
public final IFile file;
42-
43-
private ResourceChange(ChangeType type, IFile theFile, int theFlags) {
44-
resourceDeltaType = type;
45-
file = theFile;
46-
flags = theFlags;
47-
}
48-
49-
public int hashCode() { return resourceDeltaType.hashCode() + 13 + file.hashCode() + flags; }
50-
51-
public boolean equals(Object other) {
52-
if (other == null) return false;
53-
if (other == this) return true;
54-
if (other.getClass() == getClass()) {
55-
ResourceChange chg = (ResourceChange)other;
56-
return chg.file.equals(file) &&
57-
resourceDeltaType == chg.resourceDeltaType &&
58-
flags == chg.flags;
59-
}
60-
return false;
61-
}
62-
}
63-
64-
/**
65-
* @param event
66-
*/
67-
public void resourceChanged(IResourceChangeEvent event) {
68-
69-
Set<ResourceChange> itemsChanged = new HashSet<ResourceChange>();
70-
71-
switch (event.getType()) {
72-
// case IResourceChangeEvent.PRE_DELETE:
73-
// case IResourceChangeEvent.PRE_CLOSE:
74-
// case IResourceChangeEvent.PRE_BUILD:
75-
// case IResourceChangeEvent.POST_BUILD:
76-
// case IResourceChangeEvent.PRE_REFRESH:
77-
78-
case IResourceChangeEvent.POST_CHANGE:
79-
changed(itemsChanged, event.getDelta(), new NullProgressMonitor());
80-
}
81-
82-
if (itemsChanged.isEmpty()) return;
83-
84-
ReviewCodeCmd cmd = new ReviewCodeCmd(); // separate one for each thread
85-
cmd.reset();
86-
87-
for (ResourceChange chg : itemsChanged) cmd.addResource(chg.file);
88-
89-
try {
90-
cmd.performExecute();
91-
} catch (CommandException e) {
92-
PMDPlugin.getDefault().log(IStatus.ERROR, "Error processing code review upon file changes", e);
93-
}
94-
}
95-
96-
private void changed(Set<ResourceChange> itemsChanged, IResourceDelta delta, IProgressMonitor monitor) {
97-
98-
IResource rsc = delta.getResource();
99-
int flags = delta.getFlags();
100-
101-
switch (delta.getKind()) {
102-
case IResourceDelta.NO_CHANGE : return;
103-
case IResourceDelta.REMOVED :
104-
// if (rsc instanceof IProject) {
105-
// removed(itemsChanged, (IProject)rsc, delta.getFlags());
106-
// }
107-
// if (rsc instanceof IFile) {
108-
// removed(itemsChanged, (IFile)rsc, flags, true);
109-
// }
110-
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
111-
if (monitor.isCanceled()) return;
112-
changed(itemsChanged, grandkidDelta, monitor);
113-
}
114-
break;
115-
case IResourceDelta.ADDED :
116-
// if (rsc instanceof IProject) {
117-
// removed(itemsChanged, (IProject)rsc, delta.getFlags());
118-
// }
119-
if (rsc instanceof IFile) {
120-
added(itemsChanged, (IFile)rsc, flags, true);
121-
}
122-
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
123-
if (monitor.isCanceled()) return;
124-
changed(itemsChanged, grandkidDelta, monitor);
125-
}
126-
break;
127-
case IResourceDelta.CHANGED :
128-
// if (rsc instanceof IProject) {
129-
// changed(itemsChanged, (IProject)rsc, delta.getFlags());
130-
// }
131-
if (rsc instanceof IFile) {
132-
changed(itemsChanged, (IFile)rsc, flags, true);
133-
}
134-
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
135-
if (monitor.isCanceled()) return;
136-
changed(itemsChanged, grandkidDelta, monitor);
137-
}
138-
break;
139-
default :
140-
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
141-
if (monitor.isCanceled()) return;
142-
changed(itemsChanged, grandkidDelta, monitor);
143-
}
144-
}
145-
}
146-
147-
private void changed(Set<ResourceChange> itemsChanged, IFile rsc, int flags, boolean b) {
148-
149-
if ((flags & IResourceDelta.CONTENT) > 0) {
150-
itemsChanged.add( new ResourceChange(ChangeType.CHANGED, rsc, flags));
151-
}
152-
}
153-
154-
private void added(Set<ResourceChange> itemsChanged, IFile rsc, int flags, boolean b) {
155-
itemsChanged.add( new ResourceChange(ChangeType.ADDED, rsc, flags));
156-
// System.out.println("added: " + rsc);
157-
}
158-
// private void changed(Set<ResourceChange> itemsChanged, IProject rsc, int flags) {
159-
// System.out.println("changed: " + rsc);
160-
// }
161-
//
162-
//
163-
// private void removed(Set<ResourceChange> itemsChanged, IFile rsc, int flags, boolean b) {
164-
// itemsChanged.add( new ResourceChange(ChangeType.REMOVED, rsc, flags));
165-
// System.out.println("removed: " + rsc);
166-
// }
167-
//
168-
// private void removed(Set<ResourceChange> itemsChanged, IProject rsc, int flags) {
169-
// System.out.println("removed: " + rsc);
170-
// }
171-
29+
public FileChangeReviewer() {
30+
}
31+
32+
private enum ChangeType {
33+
ADDED, REMOVED, CHANGED
34+
}
35+
36+
private class ResourceChange {
37+
public final ChangeType resourceDeltaType;
38+
public final int flags;
39+
public final IFile file;
40+
41+
private ResourceChange(ChangeType type, IFile theFile, int theFlags) {
42+
resourceDeltaType = type;
43+
file = theFile;
44+
flags = theFlags;
45+
}
46+
47+
public int hashCode() {
48+
return resourceDeltaType.hashCode() + 13 + file.hashCode() + flags;
49+
}
50+
51+
public boolean equals(Object other) {
52+
if (other == null)
53+
return false;
54+
if (other == this)
55+
return true;
56+
if (other.getClass() == getClass()) {
57+
ResourceChange chg = (ResourceChange) other;
58+
return chg.file.equals(file) && resourceDeltaType == chg.resourceDeltaType && flags == chg.flags;
59+
}
60+
return false;
61+
}
62+
}
63+
64+
/**
65+
* @param event
66+
*/
67+
public void resourceChanged(IResourceChangeEvent event) {
68+
69+
Set<ResourceChange> itemsChanged = new HashSet<ResourceChange>();
70+
71+
switch (event.getType()) {
72+
// case IResourceChangeEvent.PRE_DELETE:
73+
// case IResourceChangeEvent.PRE_CLOSE:
74+
// case IResourceChangeEvent.PRE_BUILD:
75+
// case IResourceChangeEvent.POST_BUILD:
76+
// case IResourceChangeEvent.PRE_REFRESH:
77+
78+
case IResourceChangeEvent.POST_CHANGE:
79+
changed(itemsChanged, event.getDelta(), new NullProgressMonitor());
80+
}
81+
82+
if (itemsChanged.isEmpty())
83+
return;
84+
85+
ReviewCodeCmd cmd = new ReviewCodeCmd(); // separate one for each thread
86+
cmd.reset();
87+
88+
for (ResourceChange chg : itemsChanged)
89+
cmd.addResource(chg.file);
90+
91+
try {
92+
cmd.performExecute();
93+
} catch (CommandException e) {
94+
PMDPlugin.getDefault().log(IStatus.ERROR, "Error processing code review upon file changes", e);
95+
}
96+
}
97+
98+
private void changed(Set<ResourceChange> itemsChanged, IResourceDelta delta, IProgressMonitor monitor) {
99+
100+
IResource rsc = delta.getResource();
101+
int flags = delta.getFlags();
102+
103+
switch (delta.getKind()) {
104+
case IResourceDelta.NO_CHANGE:
105+
return;
106+
case IResourceDelta.REMOVED:
107+
// if (rsc instanceof IProject) {
108+
// removed(itemsChanged, (IProject)rsc, delta.getFlags());
109+
// }
110+
// if (rsc instanceof IFile) {
111+
// removed(itemsChanged, (IFile)rsc, flags, true);
112+
// }
113+
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
114+
if (monitor.isCanceled())
115+
return;
116+
changed(itemsChanged, grandkidDelta, monitor);
117+
}
118+
break;
119+
case IResourceDelta.ADDED:
120+
// if (rsc instanceof IProject) {
121+
// removed(itemsChanged, (IProject)rsc, delta.getFlags());
122+
// }
123+
if (rsc instanceof IFile) {
124+
added(itemsChanged, (IFile) rsc, flags, true);
125+
}
126+
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
127+
if (monitor.isCanceled())
128+
return;
129+
changed(itemsChanged, grandkidDelta, monitor);
130+
}
131+
break;
132+
case IResourceDelta.CHANGED:
133+
// if (rsc instanceof IProject) {
134+
// changed(itemsChanged, (IProject)rsc, delta.getFlags());
135+
// }
136+
if (rsc instanceof IFile) {
137+
changed(itemsChanged, (IFile) rsc, flags, true);
138+
}
139+
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
140+
if (monitor.isCanceled())
141+
return;
142+
changed(itemsChanged, grandkidDelta, monitor);
143+
}
144+
break;
145+
default:
146+
for (IResourceDelta grandkidDelta : delta.getAffectedChildren()) {
147+
if (monitor.isCanceled())
148+
return;
149+
changed(itemsChanged, grandkidDelta, monitor);
150+
}
151+
}
152+
}
153+
154+
private void changed(Set<ResourceChange> itemsChanged, IFile rsc, int flags, boolean b) {
155+
156+
if ((flags & IResourceDelta.CONTENT) > 0) {
157+
itemsChanged.add(new ResourceChange(ChangeType.CHANGED, rsc, flags));
158+
}
159+
}
160+
161+
private void added(Set<ResourceChange> itemsChanged, IFile rsc, int flags, boolean b) {
162+
itemsChanged.add(new ResourceChange(ChangeType.ADDED, rsc, flags));
163+
// System.out.println("added: " + rsc);
164+
}
165+
// private void changed(Set<ResourceChange> itemsChanged, IProject rsc, int
166+
// flags) {
167+
// System.out.println("changed: " + rsc);
168+
// }
169+
//
170+
//
171+
// private void removed(Set<ResourceChange> itemsChanged, IFile rsc, int
172+
// flags, boolean b) {
173+
// itemsChanged.add( new ResourceChange(ChangeType.REMOVED, rsc, flags));
174+
// System.out.println("removed: " + rsc);
175+
// }
176+
//
177+
// private void removed(Set<ResourceChange> itemsChanged, IProject rsc, int
178+
// flags) {
179+
// System.out.println("removed: " + rsc);
180+
// }
172181

173182
}

0 commit comments

Comments
 (0)