Logging adjustments:

* Adjust log pattern to include thread
* add filtering and deactivate additivity
* add logging during tests

Author: adangel

net.sourceforge.pmd.eclipse.plugin.test/META-INF/MANIFEST.MF

@@ -15,4 +15,6 @@ Require-Bundle: org.eclipse.ui,
  org.junit,
  org.apache.log4j,
  org.apache.commons.io
-Import-Package: org.slf4j
+Import-Package: ch.qos.logback.classic,
+ org.slf4j
+Bundle-Activator: net.sourceforge.pmd.eclipse.internal.TestActivator

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/internal/TestActivator.java

@@ -0,0 +1,30 @@
+/**
+ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
+ */
+
+package net.sourceforge.pmd.eclipse.internal;
+
+import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.Status;
+import org.eclipse.ui.plugin.AbstractUIPlugin;
+import org.slf4j.LoggerFactory;
+
+import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
+
+import ch.qos.logback.classic.Logger;
+
+public class TestActivator extends AbstractUIPlugin {
+
+    public TestActivator() {
+        PMDPlugin mainPlugin = PMDPlugin.getDefault();
+        Object l = LoggerFactory.getLogger("net.sourceforge.pmd");
+        if (l instanceof Logger) {
+            Logger logger = (Logger) l;
+            logger.setAdditive(true);
+        } else {
+            mainPlugin.getLog().log(new Status(IStatus.WARNING, PMDPlugin.PLUGIN_ID, "Couldn't setup logging for tests."));
+        }
+        
+    }
+
+}

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/logging/internal/LogbackConfiguration.java

@@ -13,6 +13,7 @@
 
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
 
+import ch.qos.logback.classic.Level;
 import ch.qos.logback.classic.Logger;
 import ch.qos.logback.classic.LoggerContext;
 import ch.qos.logback.classic.encoder.PatternLayoutEncoder;
@@ -43,10 +44,16 @@ public void configureLogback() {
         EclipseLogAppender logbackEclipseAppender = new EclipseLogAppender(PMDPlugin.PLUGIN_ID, getLog());
         logbackEclipseAppender.setContext(logbackContext);
         logbackEclipseAppender.setName(PMDPlugin.PLUGIN_ID);
+        ThresholdFilter filter = new ThresholdFilter();
+        filter.setContext(logbackContext);
+        filter.setLevel(Level.INFO.toString());
+        filter.start();
+        logbackEclipseAppender.addFilter(filter);
         logbackEclipseAppender.start();
 
         Logger l = logbackContext.getLogger(ROOT_LOG_ID);
         l.addAppender(logbackEclipseAppender);
+        l.setAdditive(false);
 
         if (!SLF4JBridgeHandler.isInstalled()) {
             SLF4JBridgeHandler.install();
@@ -92,7 +99,7 @@ private void configureLogs(String logFileName, String logLevel) {
 
         PatternLayoutEncoder encoder = new PatternLayoutEncoder();
         encoder.setContext(logbackContext);
-        encoder.setPattern("%d{yyyy/MM/dd HH:mm:ss,SSS} %-5p %-32c{1} %m%n");
+        encoder.setPattern("%d{yyyy/MM/dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n");
         encoder.start();
         appender.setEncoder(encoder);