Add local rules button, make ruleSetFile is stored only when needed

Author: adangel

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/properties/impl/ProjectPropertiesManagerImpl.java

@@ -331,15 +331,16 @@ private void writeProjectProperties(final IProject project, final ProjectPropert
      */
     private ProjectPropertiesTO fillTransferObject(IProjectProperties projectProperties) throws PropertiesException {
         final ProjectPropertiesTO bean = new ProjectPropertiesTO();
-        bean.setRuleSetStoredInProject(projectProperties.isRuleSetStoredInProject());
-        bean.setRuleSetFile(projectProperties.getRuleSetFile());
         bean.setWorkingSetName(projectProperties.getProjectWorkingSet() == null ? null
                 : projectProperties.getProjectWorkingSet().getName());
         bean.setIncludeDerivedFiles(projectProperties.isIncludeDerivedFiles());
         bean.setViolationsAsErrors(projectProperties.violationsAsErrors());
         bean.setFullBuildEnabled(projectProperties.isFullBuildEnabled());
 
-        if (!projectProperties.isRuleSetStoredInProject()) {
+        bean.setRuleSetStoredInProject(projectProperties.isRuleSetStoredInProject());
+        if (projectProperties.isRuleSetStoredInProject()) {
+            bean.setRuleSetFile(projectProperties.getRuleSetFile());
+        } else {
             final List<RuleSet> ruleSets = projectProperties.getProjectRuleSetList();
             final List<RuleSpecTO> rules = new ArrayList<>();
             List<String> excludePatterns = new ArrayList<>();

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java

@@ -176,6 +176,7 @@ protected Control createContents(final Composite parent) {
             ruleSetStoredInProjectButton = buildStoreRuleSetInProjectButton(ruleSetPanel);
             ruleSetFileText = buildRuleSetFileText(ruleSetPanel);
             ruleSetBrowseButton = buildRuleSetBrowseButton(ruleSetPanel);
+            buildLocalRulesButton(ruleSetPanel);
 
             data = new GridData(SWT.FILL, SWT.NONE, true, false);
             ruleSetFileText.setLayoutData(data);
@@ -327,25 +328,26 @@ public void widgetSelected(SelectionEvent e) {
         return button;
     }
 
-    //    /**
-    //     * Create the radio button for storing configuration in a project file
-    //     * 
-    //     * @param parent
-    //     *            the parent composite
-    //     */
-    //    private Button buildLocalRulesButton(final Composite parent) {
-    //        Button button = newRadioButton(parent, "Use local rules");
-    //
-    //        button.setSelection(!model.isRuleSetStoredInProject());
-    //
-    //        button.addSelectionListener(new SelectionAdapter() {
-    //            public void widgetSelected(SelectionEvent e) {
-    //                adjustControls();
-    //            }
-    //        });
-    //
-    //        return button;
-    //    }
+    /**
+     * Create the radio button for storing configuration in a project file
+     * 
+     * @param parent
+     *            the parent composite
+     */
+    private Button buildLocalRulesButton(final Composite parent) {
+        Button button = newRadioButton(parent, "Use local rules");
+
+        button.setSelection(!model.isRuleSetStoredInProject());
+
+        button.addSelectionListener(new SelectionAdapter() {
+            @Override
+            public void widgetSelected(SelectionEvent e) {
+                adjustControls();
+            }
+        });
+
+        return button;
+    }
 
     /**
      * Create the the rule set file name text.