Skip to content

Commit ef2cb88

Browse files
committed
Fix compile error in RuleTableViewerSorter
1 parent 0c7f44c commit ef2cb88

File tree

4 files changed

+13
-16
lines changed

4 files changed

+13
-16
lines changed

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/PMDPreferencePage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ private Table buildRuleTableViewer(Composite parent) {
357357

358358
ruleTableViewer.setContentProvider(new RuleSetContentProvider());
359359
ruleTableViewer.setLabelProvider(new RuleLabelProvider());
360-
ruleTableViewer.setSorter(ruleTableViewerSorter);
360+
ruleTableViewer.setComparator(ruleTableViewerSorter);
361361
ruleTableViewer.addSelectionChangedListener(new ISelectionChangedListener() {
362362
/**
363363
* @see org.eclipse.jface.viewers.ISelectionChangedListener#selectionChanged(SelectionChangedEvent)

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/RuleTableViewerSorter.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import java.util.Comparator;
3838

3939
import org.eclipse.jface.viewers.Viewer;
40-
import org.eclipse.jface.viewers.ViewerSorter;
40+
import org.eclipse.jface.viewers.ViewerComparator;
4141

4242
import net.sourceforge.pmd.Rule;
4343

@@ -48,7 +48,7 @@
4848
*
4949
*/
5050

51-
public class RuleTableViewerSorter extends ViewerSorter {
51+
public class RuleTableViewerSorter extends ViewerComparator {
5252

5353
/**
5454
* Default Rule comparator for tabular display of Rules.
@@ -145,13 +145,6 @@ public void setSortDescending(boolean sortDescending) {
145145
this.sortDescending = sortDescending;
146146
}
147147

148-
/**
149-
* @return Returns the comparator.
150-
*/
151-
public Comparator<Rule> getComparator() {
152-
return comparator;
153-
}
154-
155148
/**
156149
* Set a comparator. If the same comparator is already set, then change the
157150
* sorting order.
@@ -167,10 +160,14 @@ public void setComparator(Comparator<Rule> comparator) {
167160
}
168161
}
169162

170-
/**
171-
* @see org.eclipse.jface.viewers.ViewerSorter#compare(org.eclipse.jface.viewers.Viewer,
172-
* java.lang.Object, java.lang.Object)
173-
*/
163+
@Override
164+
protected Comparator<? super String> getComparator() {
165+
// safe-guard
166+
throw new UnsupportedOperationException("Getting the underlaying comparator is not allowed"
167+
+ " - since a different one is actually used");
168+
}
169+
170+
@Override
174171
public int compare(Viewer viewer, Object e1, Object e2) {
175172
int result = comparator.compare((Rule) e1, (Rule) e2);
176173
return sortDescending ? 0 - result : result;

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ private Table buildAvailableRulesTableViewer(final Composite parent) {
450450

451451
availableRulesTableViewer.setContentProvider(new RuleSetContentProvider());
452452
availableRulesTableViewer.setLabelProvider(new RuleLabelProvider());
453-
availableRulesTableViewer.setSorter(availableRuleTableViewerSorter);
453+
availableRulesTableViewer.setComparator(availableRuleTableViewerSorter);
454454
availableRulesTableViewer.setColumnProperties(new String[] { PMDPreferencePage.PROPERTY_LANGUAGE,
455455
PMDPreferencePage.PROPERTY_RULESET_NAME, PMDPreferencePage.PROPERTY_RULE_NAME,
456456
// PMDPreferencePage.PROPERTY_SINCE,

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDPropertyPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ private Table buildAvailableRulesTableViewer(final Composite parent) {
389389

390390
availableRulesTableViewer.setContentProvider(new RuleSetContentProvider());
391391
availableRulesTableViewer.setLabelProvider(new RuleLabelProvider());
392-
availableRulesTableViewer.setSorter(availableRuleTableViewerSorter);
392+
availableRulesTableViewer.setComparator(availableRuleTableViewerSorter);
393393
availableRulesTableViewer.setColumnProperties(
394394
new String[] { PMDPreferencePage.PROPERTY_LANGUAGE, PMDPreferencePage.PROPERTY_RULESET_NAME,
395395
PMDPreferencePage.PROPERTY_RULE_NAME, PMDPreferencePage.PROPERTY_SINCE,

0 commit comments

Comments
 (0)