Skip to content

Commit f4215dd

Browse files
committed
Fixes #94: Changing a project's PMD configuration no longer prompts for build
1 parent ff25201 commit f4215dd

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

ReleaseNotes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ This is a bugfix release.
1313

1414
### Fixed Issues
1515

16+
* [#94](https://github.com/pmd/pmd-eclipse-plugin/issues/94): Changing a project's PMD configuration no longer prompts for build
17+
1618
## 07-March-2019: 4.1.0.v20190307-2036
1719

1820
This is a minor release.

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDPropertyPageController.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ public boolean performOk() {
142142
cmd.setViolationsAsErrors(propertyPageBean.violationsAsErrors());
143143
cmd.setUserInitiated(true);
144144
cmd.performExecute();
145+
cmd.join(); // need to wait, otherwise cmd.isNeedRebuild() is not updated
145146

146147
// If rebuild is needed, then rebuild the project
147148
LOG.debug("Updating command terminated, checking whether the project need to be rebuilt");

0 commit comments

Comments
 (0)