From 49a65a8426f152ae4bbf276fb1c497a0c6d2cec3 Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 12 Sep 2025 10:49:48 +0200
Subject: [PATCH] Bump PMD from 7.16.0 to 7.17.0

---
 ReleaseNotes.md                                               | 1 +
 .../sourceforge/pmd/eclipse/ui/dialogs/NewPropertyDialog.java | 1 -
 .../pmd/eclipse/ui/preferences/editors/TypeText.java          | 2 +-
 .../eclipse/ui/preferences/panelmanagers/FormArranger.java    | 1 -
 .../sourceforge/pmd/eclipse/ui/views/TableColumnSorter.java   | 4 ++--
 .../pmd/eclipse/ui/views/ast/ASTContentProvider.java          | 2 +-
 pom.xml                                                       | 4 ++--
 7 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/ReleaseNotes.md b/ReleaseNotes.md
index 2cf0e9f2..077f1015 100644
--- a/ReleaseNotes.md
+++ b/ReleaseNotes.md
@@ -12,6 +12,7 @@ Eclipse Update Site:
 This is a minor release.
 
 ### 🚀 New and noteworthy
+* Update to PMD 7.17.0
 * Support for Eclipse 2025-09 added
 * Support for Eclipse 2024-09 removed
 
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/dialogs/NewPropertyDialog.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/dialogs/NewPropertyDialog.java
index 8a5749d0..1db42356 100755
--- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/dialogs/NewPropertyDialog.java
+++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/dialogs/NewPropertyDialog.java
@@ -84,7 +84,6 @@ public NewPropertyDialog(Shell parent, PropertySource theSource, ValueChangeList
      * @deprecated use {@link #NewPropertyDialog(Shell, PropertySource, ValueChangeListener)} instead.
      */
     @Deprecated // for removal
-    @SuppressWarnings("PMD.UnusedFormalParameter")
     public NewPropertyDialog(Shell parent, Map<Class<?>, EditorFactory<?>> theEditorFactoriesByValueType,
             PropertySource theSource, ValueChangeListener theChangeListener) {
         this(parent, theSource, theChangeListener);
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/editors/TypeText.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/editors/TypeText.java
index 4f5b5857..98bf70d4 100644
--- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/editors/TypeText.java
+++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/editors/TypeText.java
@@ -32,7 +32,7 @@ public class TypeText extends Composite {
     private Text text;
     private boolean acceptPrimitives;
 
-    public TypeText(Composite parent, int style, boolean primitivesOK, String thePromptText) { // NOPMD: thePromptText is unused TODO
+    public TypeText(Composite parent, int style, boolean primitivesOK, String thePromptText) {
         super(parent, SWT.None);
 
         GridLayout layout = new GridLayout(1, false);
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/FormArranger.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/FormArranger.java
index cc721d33..408a6db3 100644
--- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/FormArranger.java
+++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/panelmanagers/FormArranger.java
@@ -65,7 +65,6 @@ public FormArranger(Composite theParent, ValueChangeListener listener, SizeChang
      * @deprecated Use {@link #FormArranger(Composite, ValueChangeListener, SizeChangeListener)} instead.
      */
     @Deprecated // for removal
-    @SuppressWarnings("PMD.UnusedFormalParameter")
     public FormArranger(Composite theParent, Map<Class<?>, EditorFactory<?>> factories, ValueChangeListener listener,
             SizeChangeListener sizeListener) {
         this(theParent, listener, sizeListener);
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/TableColumnSorter.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/TableColumnSorter.java
index a42cab97..0b7540c9 100644
--- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/TableColumnSorter.java
+++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/TableColumnSorter.java
@@ -21,7 +21,7 @@ public class TableColumnSorter extends ViewerSorter {
      * @param order,
      *            the Direction to sort by, -1 (desc) or 1 (asc)
      */
-    public TableColumnSorter(TreeColumn column, int order) { // NOPMD: TODO unused formal parameters...
+    public TableColumnSorter(TreeColumn column, int order) {
         super();
 
         // column.getParent().setSortColumn(column);
@@ -34,7 +34,7 @@ public TableColumnSorter(TreeColumn column, int order) { // NOPMD: TODO unused f
      * @param order,
      *            the Direction to sort by, -1 (desc) or 1 (asc)
      */
-    public TableColumnSorter(TableColumn column, int order) { // NOPMD: TODO unused formal parameters...
+    public TableColumnSorter(TableColumn column, int order) {
         super();
 
         // column.getParent().setSortColumn(column);
diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ast/ASTContentProvider.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ast/ASTContentProvider.java
index 3a4a5d75..171cf537 100644
--- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ast/ASTContentProvider.java
+++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/ast/ASTContentProvider.java
@@ -47,7 +47,7 @@ public ASTContentProvider(boolean includeImportsFlag, boolean includeCommentsFla
         includeComments = includeCommentsFlag;
     }
 
-    public ASTContentProvider(Set<Class<?>> theHiddenNodeTypes) { // NOPMD: unused formal parameter TODO
+    public ASTContentProvider(Set<Class<?>> theHiddenNodeTypes) {
         // hiddenNodeTypes = theHiddenNodeTypes;
     }
 
diff --git a/pom.xml b/pom.xml
index d7a55b7f..32ec3fe3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -21,12 +21,12 @@
     <!-- https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md and https://github.com/eclipse-tycho/tycho/releases -->
     <tycho.version>4.0.10</tycho.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <pmd.version>7.16.0</pmd.version>
+    <pmd.version>7.17.0</pmd.version>
     <pmd.build-tools.version>34</pmd.build-tools.version>
     <checkstyle.version>10.26.1</checkstyle.version>
     <checkstyle.plugin.version>3.6.0</checkstyle.plugin.version>
     <pmd.plugin.version>3.27.0</pmd.plugin.version>
-    <pmd.check.version>7.16.0</pmd.check.version>
+    <pmd.check.version>7.17.0</pmd.check.version>
 
     <keystorePath>.ci/files/pmd-eclipse-plugin.p12</keystorePath>
     <keystore>${basedir}/${keystorePath}</keystore>