Update manual integration test for OracleDBUtils (#129)

The project OracleDBUtils has been added
with pmd/pmd#5539

Author: adangel

History.md

@@ -20,6 +20,7 @@ projects. You might need to add `<tag>master</tag>` for some projects.
 ## Fixed Issues
 * [#126](https://github.com/pmd/pmd-regression-tester/pull/126): Fix integration tests
 * [#127](https://github.com/pmd/pmd-regression-tester/pull/127): Fix manual integration tests
+* [#129](https://github.com/pmd/pmd-regression-tester/pull/129): Update manual integration tests
 
 ## External Contributions
 

test/manual_integration_tests.rb

@@ -46,23 +46,23 @@ def test_case_1_single_java_rule_changed
     assert_equal(0, @summary[:violations][:changed], 'found changed violations')
     assert_equal(0, @summary[:violations][:new], 'found new violations')
     # These are the artificially created false-negatives for AbstractClassWithoutAbstractMethod rule
-    # checkstyle: 195 violations
-    # spring-framework: 280 violations
-    # openjdk11: 29 violations
-    # java-regression-tests: 1 violation
+    # checkstyle: 195 removed violations
+    # spring-framework: 280 removed violations
+    # openjdk11: 29 removed violations
+    # java-regression-tests: 1 removed violation
     # -> total = 505
     assert_equal(195 + 280 + 29 + 1, @summary[:violations][:removed], 'found removed violations')
 
     # errors might have been caused in the baseline for other rules (only visible in the stacktrace)
     # hence they might appear as removed
 
+    # project "OracleDBUtils" has 2 errors removed, since we only executed java rules
     # project "apex-link" has 2 errors removed, since we only executed java rules
-    # project "checkstyle" has 0 errors removed and 1 changed
+    # project "checkstyle" has 1 errors removed (that's an sql file...) and 1 changed
     # project "openjdk-11" has 0 errors removed or changed
-    # project "spring-framework" has 0 errors removed or changed
+    # project "spring-framework" has 20 errors removed (these are all sql files...) and 0 changed
     # project "java-regression-tests" has 0 errors removed or changed
-    # each project has 1 config error removed (LoosePackageCoupling dysfunctional): in total 7 config errors removed
-    assert_equal(2, @summary[:errors][:removed], 'found removed errors')
+    assert_equal(2 + 2 + 1 + 20, @summary[:errors][:removed], 'found removed errors')
     # The stack overflow exception might vary in the beginning/end of the stack frames shown
     # This stack overflow error is from checkstyle's InputIndentationLongConcatenatedString.java
     # instead of assert_equal(0, @summary[:errors][:changed], 'found changed errors')
@@ -71,11 +71,12 @@ def test_case_1_single_java_rule_changed
     assert_equal(0, @summary[:errors][:new], 'found new errors')
     assert_equal(0, @summary[:configerrors][:changed], 'found changed configerrors')
     assert_equal(0, @summary[:configerrors][:new], 'found new configerrors')
-    assert_equal(7, @summary[:configerrors][:removed], 'found removed configerrors')
+    # each project has 1 config error removed (LoosePackageCoupling dysfunctional): in total 8 config errors removed
+    assert_equal(8, @summary[:configerrors][:removed], 'found removed configerrors')
 
     assert_equal("This changeset changes 0 violations,\n" \
                  "introduces 0 new violations, 0 new errors and 0 new configuration errors,\n" \
-                 'removes 505 violations, 2 errors and 7 configuration errors.',
+                 'removes 505 violations, 25 errors and 8 configuration errors.',
                  create_summary_message)
 
     assert_file_equals("#{PATCHES_PATH}/expected_patch_config_1.xml", 'target/reports/diff/patch_config.xml')
@@ -100,12 +101,13 @@ def test_case_2_single_xpath_rule_changed
     # errors might have been caused in the baseline for other rules (only visible in the stacktrace)
     # hence they might appear as removed
 
+    # project "OracleDBUtils" has 2 errors removed, since we only executed java rules
     # project "apex-link" has 2 errors removed, since we only executed java rules
-    # project "checkstyle" has 0 errors removed and 1 errors changed
+    # project "checkstyle" has 1 error removed (that's an sql file...) and 1 error changed
     # project "openjdk-11" has 0 errors removed or changed
-    # project "spring-framework" has 0 errors removed or changed
-    # each project has 1 config error removed (LoosePackageCoupling dysfunctional): in total 7 config errors removed
-    assert_equal(2, @summary[:errors][:removed], 'found removed errors')
+    # project "spring-framework" has 20 errors removed (sql files) and 0 changed
+    # each project has 1 config error removed (LoosePackageCoupling dysfunctional): in total 8 config errors removed
+    assert_equal(2 + 2 + 1 + 20, @summary[:errors][:removed], 'found removed errors')
     # The stack overflow exception might vary in the beginning/end of the stack frames shown
     # This stack overflow error is from checkstyle's InputIndentationLongConcatenatedString.java
     # instead of assert_equal(0, @summary[:errors][:changed], 'found changed errors')
@@ -114,11 +116,11 @@ def test_case_2_single_xpath_rule_changed
     assert_equal(0, @summary[:errors][:new], 'found new errors')
     assert_equal(0, @summary[:configerrors][:changed], 'found changed configerrors')
     assert_equal(0, @summary[:configerrors][:new], 'found new configerrors')
-    assert_equal(7, @summary[:configerrors][:removed], 'found removed configerrors')
+    assert_equal(8, @summary[:configerrors][:removed], 'found removed configerrors')
 
     assert_equal("This changeset changes 0 violations,\n" \
                  "introduces 0 new violations, 0 new errors and 0 new configuration errors,\n" \
-                 'removes 22 violations, 2 errors and 7 configuration errors.',
+                 'removes 22 violations, 25 errors and 8 configuration errors.',
                  create_summary_message)
 
     assert_file_equals("#{PATCHES_PATH}/expected_patch_config_2.xml", 'target/reports/diff/patch_config.xml')
@@ -271,6 +273,7 @@ def assert_main_baseline
     assert_main_baseline_project('apex-link', 10 * 1024)
     assert_main_baseline_project('fflib-apex-common', 400 * 1024)
     assert_main_baseline_project('Schedul-o-matic-9000', 20 * 1024)
+    assert_main_baseline_project('OracleDBUtils', 400 * 1024)
   end
 
   def assert_main_baseline_project(project_name, report_size_in_bytes)

test/resources/manual_integration_tests/expected_patch_config_3.xml

@@ -4,7 +4,10 @@
     xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
-    <description>Every apex and java rule in PMD which is used for the regression tests with pmdtester</description>
+    <description>Every apex, plsql and java rule in PMD which is used for the regression tests with pmdtester</description>
+
+    <!-- plsql: avoid long parse time by skipping the problematic file fow now, see #5521 -->
+    <exclude-pattern>.*/OracleDBUtils/p_utils_tests.sql</exclude-pattern>
 
     <rule ref="category/apex/bestpractices.xml" />
     <rule ref="category/apex/codestyle.xml" />
@@ -15,6 +18,15 @@
     <rule ref="category/apex/performance.xml" />
     <rule ref="category/apex/security.xml" />
 
+    <rule ref="category/plsql/bestpractices.xml" />
+    <rule ref="category/plsql/codestyle.xml" />
+    <rule ref="category/plsql/design.xml" />
+    <!-- no rules <rule ref="category/plsql/documentation.xml" /> -->
+    <rule ref="category/plsql/errorprone.xml" />
+    <!-- no rules <rule ref="category/plsql/multithreading.xml" /> -->
+    <!-- no rules <rule ref="category/plsql/performance.xml" /> -->
+    <!-- no rules <rule ref="category/plsql/security.xml" /> -->
+
     <rule ref="category/java/bestpractices.xml" />
     <rule ref="category/java/codestyle.xml" />
     <rule ref="category/java/design.xml" />