Fix rubocop offenses

Author: oowekyala

lib/pmdtester/builders/diff_report/violations.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'differ'
 
 # Contains methods to write out html for the violations.
@@ -75,7 +76,7 @@ def build_violation_table_row(doc, key, pmd_violation)
   end
 
   def diff_fragments(doc, violation)
-    old_message = violation.attrs["oldMessage"]
+    old_message = violation.attrs['oldMessage']
     new_message = violation.text
     diff = Differ.diff_by_word(old_message, new_message)
     doc << diff.format_as(:html)

lib/pmdtester/builders/html_report_builder.rb

@@ -47,7 +47,7 @@ def copy_css(report_dir)
       FileUtils.copy_entry(CSS_SRC_DIR, css_dest_dir)
     end
 
-    def build_table_content_for(doc, removed_size, new_size, changed_size=nil)
+    def build_table_content_for(doc, removed_size, new_size, changed_size = nil)
       doc.span(class: 'removed') { doc.text "-#{removed_size}" }
       if changed_size
         doc.text ' | '

lib/pmdtester/pmd_violation.rb

@@ -59,13 +59,13 @@ def initialize(attrs, branch)
       @text = ''
     end
 
-    def is_same_modulo_message?(other)
+    def same_modulo_message?(other)
       @attrs['beginline'].eql?(other.attrs['beginline']) &&
-          @attrs['rule'].eql?(other.attrs['rule'])
+        @attrs['rule'].eql?(other.attrs['rule'])
     end
 
     def try_merge?(other)
-      if branch != BASE && @branch != other.branch && is_same_modulo_message?(other)
+      if branch != BASE && @branch != other.branch && same_modulo_message?(other)
         @changed = true
         @attrs['oldMessage'] = other.text
         true
@@ -75,7 +75,7 @@ def try_merge?(other)
     end
 
     def eql?(other)
-      is_same_modulo_message?(other) &&
+      same_modulo_message?(other) &&
         @text.eql?(other.text)
     end
 

lib/pmdtester/report_diff.rb

@@ -146,11 +146,11 @@ def build_diffs(base_hash, patch_hash)
     # @param diff_violations a hash { filename => list[violation]}, containing those that changed
     def merge_changed_violations(diff_violations)
       diff_violations.each do |fname, different|
-        diff_violations[fname] = different.dup.delete_if { |v|
+        diff_violations[fname] = different.dup.delete_if do |v|
           v.branch == BASE &&
-              # try_merge will set v2.changed = true if it succeeds
-              different.any? { |v2| v2.try_merge?(v) }
-        }
+            # try_merge will set v2.changed = true if it succeeds
+            different.any? { |v2| v2.try_merge?(v) }
+        end
       end
     end