Skip to content

Commit 33891a1

Browse files
committed
Revert "Skip tests completely while building PMD"
We need to compile tests, as pmd-ant is depending on the test artifacts from pmd-core... This reverts commit 9cb700b.
1 parent b5c89c6 commit 33891a1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/pmdtester/builders/pmd_report_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def build_pmd_with_maven
256256
# build command since PMD migrated to central portal
257257
'./mvnw clean package -V ' \
258258
'-PfastSkip ' \
259-
'-Dmaven.test.skip=true ' \
259+
'-DskipTests ' \
260260
'-T1C -B'
261261
else
262262
extra_java_home = "#{Dir.home}/openjdk11"

test/test_pmd_report_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ def stub_pmd_build_maven_new_pmd7_build
388388
PmdTester::Cmd.stubs(:execute_successfully).with do |cmd, extra_java_home|
389389
if cmd == './mvnw clean package -V ' \
390390
'-PfastSkip ' \
391-
'-Dmaven.test.skip=true ' \
391+
'-DskipTests ' \
392392
'-T1C -B' &&
393393
extra_java_home.nil?
394394
FileUtils.mkdir_p 'pmd-dist/target'

0 commit comments

Comments
 (0)